Commit 653fdb7a authored by Levin Zimmermann's avatar Levin Zimmermann

.

parent 7cd8b7c2
...@@ -185,11 +185,25 @@ func NewServer(fs RawFileSystem, mountPoint string, opts *MountOptions) (*Server ...@@ -185,11 +185,25 @@ func NewServer(fs RawFileSystem, mountPoint string, opts *MountOptions) (*Server
o.Name = strings.Replace(name[:l], ",", ";", -1) o.Name = strings.Replace(name[:l], ",", ";", -1)
} }
// XXX: Is this really the correct place where we should adjust
// the options? How's if we simply change 'optionsStrings' method?
//
// git grep "optionsStrings"
// fuse/mount_darwin.go: "-o", strings.Join(opts.optionsStrings(), ","),
// fuse/mount_linux.go: if s := opts.optionsStrings(); len(s) > 0 {
// fuse/server.go: for _, s := range o.optionsStrings() {
// fuse/server.go:func (o *MountOptions) optionsStrings() []string {
//
// Because 'optionsStrings' is called in the mount_* files, maybe it's indeed
// sufficient to change optionsStrings?
// This also makes sense, because we don't change the internal representation of
// our mount options with the escaped version, which is more difficult to handle
// and which shouldn't matter for the user. go-fuse could take care of escaping
// without the user having to think about this..
for _, s := range o.optionsStrings() { for _, s := range o.optionsStrings() {
if strings.Contains(s, ",") {
escapeComma(s) escapeComma(s)
} }
}
maxReaders := runtime.GOMAXPROCS(0) maxReaders := runtime.GOMAXPROCS(0)
if maxReaders < minMaxReaders { if maxReaders < minMaxReaders {
...@@ -251,6 +265,21 @@ func NewServer(fs RawFileSystem, mountPoint string, opts *MountOptions) (*Server ...@@ -251,6 +265,21 @@ func NewServer(fs RawFileSystem, mountPoint string, opts *MountOptions) (*Server
return ms, nil return ms, nil
} }
func escapeComma(optionValue string) string {
// Perhaps if clause isn't even needed.
// We need to loop through each character of the string
// anyway, so we'll catch each comma anyway.
//
// Maybe it's very slightly more performant if we initially
// test if it contains a ','?
//
// But perhaps strings.Replace() is equally fast..
// if strings.Contains(s, ",") {}
return strings.Replace(optionValue, ",", "//", -1)
}
func (o *MountOptions) optionsStrings() []string { func (o *MountOptions) optionsStrings() []string {
var r []string var r []string
r = append(r, o.Options...) r = append(r, o.Options...)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment