Commit 7ee02038 authored by Kirill Smelkov's avatar Kirill Smelkov

bigfile/py: It is ok to have .fileh_open() as BigFile method

There was an XXX of whether fileh_open should be a BigFile method or
global function. However if it would be a global function it will need
to anyway accept file parameter to indicate which file is opened, and
that in turn suggests that it should be a file method. Remove XXX.
parent 2b457640
...@@ -128,7 +128,7 @@ typedef struct PyBigFileH PyBigFileH; ...@@ -128,7 +128,7 @@ typedef struct PyBigFileH PyBigFileH;
* BigFile that can be implemented in python * BigFile that can be implemented in python
* *
* Allows subclasses to implement .loadblk() (& friends) in python. * Allows subclasses to implement .loadblk() (& friends) in python.
* For users .fileh_open() is exposed to get to file handles. XXX <- should be not in this class? * For users .fileh_open() is exposed to get to file handles.
*/ */
struct PyBigFile { struct PyBigFile {
PyObject; PyObject;
...@@ -1030,7 +1030,6 @@ static PyMemberDef pyfile_members[] = { ...@@ -1030,7 +1030,6 @@ static PyMemberDef pyfile_members[] = {
}; };
static /*const*/ PyMethodDef pyfile_methods[] = { static /*const*/ PyMethodDef pyfile_methods[] = {
// XXX should be separate BigFileH ctor or fileh_open function?
{"fileh_open", pyfileh_open, METH_VARARGS, "fileh_open(ram=None) -> new file handle"}, {"fileh_open", pyfileh_open, METH_VARARGS, "fileh_open(ram=None) -> new file handle"},
{NULL} {NULL}
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment