From d8924d486ddfa148be697afa85e0d4ad37263a18 Mon Sep 17 00:00:00 2001
From: Kirill Smelkov <kirr@nexedi.com>
Date: Thu, 1 Jun 2017 13:30:13 +0300
Subject: [PATCH] erp5_data_notebook: Add FIXME about ZBigArray not being
 serializable

ZBigArrays were omitted from being saved in notebooks in 5fb16acd
(erp5_data_notebook: Don't save ZBigArray in data notebook. It may be
too big that zope process may crash.).

However since ZBigArrays are regular ZODB objects with persistent
references to other ZODB objects there is no reason for us not to be able to
serialize them.

Add corresponding FIXME with link to more context.

/reviewed-by TrustMe
---
 .../portal_components/extension.erp5.JupyterCompile.py         | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/bt5/erp5_data_notebook/ExtensionTemplateItem/portal_components/extension.erp5.JupyterCompile.py b/bt5/erp5_data_notebook/ExtensionTemplateItem/portal_components/extension.erp5.JupyterCompile.py
index e5129b3549..40b1f4c3c5 100644
--- a/bt5/erp5_data_notebook/ExtensionTemplateItem/portal_components/extension.erp5.JupyterCompile.py
+++ b/bt5/erp5_data_notebook/ExtensionTemplateItem/portal_components/extension.erp5.JupyterCompile.py
@@ -34,6 +34,9 @@ well_known_unserializable_type_tuple = (ModuleType, Record)
 # ZBigArray may not be available
 try:
   from wendelin.bigarray.array_zodb import ZBigArray
+  # FIXME ZBigArrays are regular ZODB objects and must be serializable
+  # FIXME the bug is probably in CanSerialize()
+  # FIXME -> see https://lab.nexedi.com/nexedi/erp5/commit/5fb16acd#note_33582 for details
   well_known_unserializable_type_tuple = tuple(list(well_known_unserializable_type_tuple) + [ZBigArray])
 except ImportError:
   pass
-- 
2.30.9