• Timothy Andrew's avatar
    Add integration tests around OAuth login. · e936db96
    Timothy Andrew authored
    - There was previously a test for `saml` login in `login_spec`, but this didn't
      seem to be passing. A lot of things didn't seem right here, and I suspect that
      this test hasn't been running. I'll investigate this further.
    
    - It took almost a whole working day to figure out this line:
    
        OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') }
    
      As always, it's obvious in retrospect, but it took some digging to figure out
      tests were failing and returning 404s during the callback phase.
    
    - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
    e936db96
_omniauth_box.html.haml 905 Bytes