Merge branch 'leave-group' into 'master'

User should be able to leave group. If not - show him proper message
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

See merge request !743

CHANGELOG

@@ -30,6 +30,7 @@ v 7.12.0 (unreleased)
   - Clarify navigation labels for Project Settings and Group Settings.
   - Move user avatar and logout button to sidebar
   - You can not remove user if he/she is an only owner of group
+  - User should be able to leave group. If not - show him proper message
 
 v 7.11.4
   - Fix missing bullets when creating lists

app/controllers/groups/group_members_controller.rb

@@ -65,10 +65,14 @@ class Groups::GroupMembersController < Groups::ApplicationController
     if can?(current_user, :destroy_group_member, @group_member)
       @group_member.destroy
       redirect_to(dashboard_groups_path, notice: "You left #{group.name} group.")
+    else
+      if @group.last_owner?(current_user)
+        redirect_to(dashboard_groups_path, alert: "You can not leave #{group.name} group because you're the last owner. Transfer or delete the group.")
       else
         return render_403
       end
     end
+  end
 
   protected
 

app/views/dashboard/groups/index.html.haml

@@ -23,8 +23,7 @@
               %i.fa.fa-cogs
               Settings
 
-          - if can?(current_user, :destroy_group_member, group_member)
-            = link_to leave_group_group_members_path(group), data: { confirm: leave_group_message(group.name) }, method: :delete, class: "btn-sm btn btn-grouped", title: 'Remove user from group' do
+          = link_to leave_group_group_members_path(group), data: { confirm: leave_group_message(group.name) }, method: :delete, class: "btn-sm btn btn-grouped", title: 'Leave this group' do
             %i.fa.fa-sign-out
             Leave
 

features/dashboard/group.feature

@@ -24,7 +24,8 @@ Feature: Dashboard Group
     When I visit dashboard groups page
     Then I should see group "Owned" in group list
     Then I should see group "Guest" in group list
-    Then I should not see the "Leave" button for group "Owned"
+    When I click on the "Leave" button for group "Owned"
+    Then I should see the "Can not leave message"
 
   @javascript
   Scenario: Guest should be able to leave from group

features/steps/dashboard/group.rb

@@ -60,4 +60,8 @@ class Spinach::Features::DashboardGroup < Spinach::FeatureSteps
     page.should have_content "Samurai"
     page.should have_content "Tokugawa Shogunate"
   end
+
+  step 'I should see the "Can not leave message"' do
+    page.should have_content "You can not leave Owned group because you're the last owner"
+  end
 end