Merge branch '49388-refactor' into 'master'

Refactor helper in environments controller for clarity

See merge request gitlab-org/gitlab-ce!24781

app/controllers/projects/environments_controller.rb

@@ -182,11 +182,11 @@ class Projects::EnvironmentsController < Projects::ApplicationController
   end
 
   def serialize_environments(request, response, nested = false)
-    serializer = EnvironmentSerializer
+    EnvironmentSerializer
       .new(project: @project, current_user: @current_user)
+      .tap { |serializer| serializer.within_folders if nested }
       .with_pagination(request, response)
-    serializer = serializer.within_folders if nested
-    serializer.represent(@environments)
+      .represent(@environments)
   end
 
   def authorize_stop_environment!