Commit 5bfca3b1 authored by Annabel Dunstone's avatar Annabel Dunstone

Add data attributes to builds

parent 4d32a8b7
...@@ -16,11 +16,11 @@ ...@@ -16,11 +16,11 @@
clearInterval(Build.interval); clearInterval(Build.interval);
this.bp = Breakpoints.get(); this.bp = Breakpoints.get();
this.hideSidebar(); this.hideSidebar();
this.displayTestStatuses();
$('.js-build-sidebar').niceScroll(); $('.js-build-sidebar').niceScroll();
$(document).off('click', '.js-sidebar-build-toggle').on('click', '.js-sidebar-build-toggle', this.toggleSidebar); $(document).off('click', '.js-sidebar-build-toggle').on('click', '.js-sidebar-build-toggle', this.toggleSidebar);
$(window).off('resize.build').on('resize.build', this.hideSidebar); $(window).off('resize.build').on('resize.build', this.hideSidebar);
this.updateArtifactRemoveDate(); this.updateArtifactRemoveDate();
this.displayTestStatuses();
if ($('#build-trace').length) { if ($('#build-trace').length) {
this.getInitialBuildTrace(); this.getInitialBuildTrace();
this.initScrollButtonAffix(); this.initScrollButtonAffix();
...@@ -134,21 +134,11 @@ ...@@ -134,21 +134,11 @@
}; };
Build.prototype.displayTestStatuses = function() { Build.prototype.displayTestStatuses = function() {
$jobTopPosition = $('.build-job').first().offset().top; $jobs = $('.build-job');
$dropdownCounter = []; jobjects = $jobs.map(function () {
return $(this).data();
$('.build-job a').each(function() { });
if ($(this).offset().top > $jobTopPosition) { console.log(jobjects);
$dropdownCounter.push($(this));
$('.overflow-jobs > li').append($(this));
}
})
$('.more-tests').text('More (' + $dropdownCounter.length + ')');
if ($('.overflow-jobs > li > a').length == 0) {
$('.overflow-jobs-dropdown').hide();
}
}; };
return Build; return Build;
......
...@@ -74,14 +74,7 @@ ...@@ -74,14 +74,7 @@
} }
} }
.overflow-jobs-dropdown { .jobs-dropdown {
float: right;
padding: 7px 0 7px 5px;
.dropdown-menu-toggle {
width: auto;
border: none;
}
svg { svg {
position: relative; position: relative;
......
...@@ -7,17 +7,24 @@ ...@@ -7,17 +7,24 @@
- builds = @build.pipeline.builds.latest.to_a - builds = @build.pipeline.builds.latest.to_a
- if builds.size > 1 - if builds.size > 1
.dropdown.overflow-jobs-dropdown .dropdown.stage
%button.dropdown-menu-toggle{type: 'button', 'data-toggle' => 'dropdown'} %button.dropdown-menu-toggle{type: 'button', 'data-toggle' => 'dropdown'}
%span.more-tests More %span.more-tests More
= icon('caret-down') = icon('caret-down')
%ul.dropdown-menu.dropdown-menu-align-right.overflow-jobs %ul.dropdown-menu.overflow-jobs
- builds.each do |build|
%li %li
%ul.nav-links.no-top.no-bottom %a= build.stage
- statuses = ["failed", "pending", "running", "canceled", "skipped", "success"] - statuses = ["failed", "pending", "running", "canceled", "skipped", "success"]
.dropdown.jobs-dropdown
%button.dropdown-menu-toggle{type: 'button', 'data-toggle' => 'dropdown'}
%span.more-tests More
= icon('caret-down')
%ul.dropdown-menu.overflow-jobs
- statuses.each do |build_status| - statuses.each do |build_status|
- builds.select{|build| build.status == build_status}.each do |build| - builds.select{|build| build.status == build_status}.each do |build|
%li.build-job{class: ('active' if build == @build) } %li.build-job{class: ('active' if build == @build), data: {id: build.id, name: build.name, status: build.status}}
= link_to namespace_project_build_path(@project.namespace, @project, build) do = link_to namespace_project_build_path(@project.namespace, @project, build) do
= ci_icon_for_status(build.status) = ci_icon_for_status(build.status)
%span %span
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment