Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
5d709e7e
Commit
5d709e7e
authored
Oct 02, 2018
by
Martin Wortschack
Committed by
Phil Hughes
Oct 02, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve "Selecting an autofill suggestion for project name will not update the project slug"
parent
1883e97e
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
5 deletions
+9
-5
app/assets/javascripts/projects/project_new.js
app/assets/javascripts/projects/project_new.js
+1
-1
changelogs/unreleased/52035-selecting-an-autofill-suggestion-for-project-name-will-not-update-the-project-slug.yml
...ion-for-project-name-will-not-update-the-project-slug.yml
+5
-0
spec/features/projects/import_export/import_file_spec.rb
spec/features/projects/import_export/import_file_spec.rb
+3
-4
No files found.
app/assets/javascripts/projects/project_new.js
View file @
5d709e7e
...
@@ -147,7 +147,7 @@ const bindEvents = () => {
...
@@ -147,7 +147,7 @@ const bindEvents = () => {
$projectImportUrl
.
keyup
(()
=>
deriveProjectPathFromUrl
(
$projectImportUrl
));
$projectImportUrl
.
keyup
(()
=>
deriveProjectPathFromUrl
(
$projectImportUrl
));
$projectName
.
keyup
(
()
=>
{
$projectName
.
on
(
'
keyup change
'
,
()
=>
{
onProjectNameChange
(
$projectName
,
$projectPath
);
onProjectNameChange
(
$projectName
,
$projectPath
);
hasUserDefinedProjectPath
=
$projectPath
.
val
().
trim
().
length
>
0
;
hasUserDefinedProjectPath
=
$projectPath
.
val
().
trim
().
length
>
0
;
});
});
...
...
changelogs/unreleased/52035-selecting-an-autofill-suggestion-for-project-name-will-not-update-the-project-slug.yml
0 → 100644
View file @
5d709e7e
---
title
:
Update project path on project name autofill
merge_request
:
22016
author
:
type
:
other
spec/features/projects/import_export/import_file_spec.rb
View file @
5d709e7e
...
@@ -21,8 +21,9 @@ describe 'Import/Export - project import integration test', :js do
...
@@ -21,8 +21,9 @@ describe 'Import/Export - project import integration test', :js do
context
'when selecting the namespace'
do
context
'when selecting the namespace'
do
let
(
:user
)
{
create
(
:admin
)
}
let
(
:user
)
{
create
(
:admin
)
}
let!
(
:namespace
)
{
user
.
namespace
}
let!
(
:namespace
)
{
user
.
namespace
}
let
(
:project_name
)
{
'Test Project Name'
+
SecureRandom
.
hex
}
let
(
:randomHex
)
{
SecureRandom
.
hex
}
let
(
:project_path
)
{
'test-project-path'
+
SecureRandom
.
hex
}
let
(
:project_name
)
{
'Test Project Name'
+
randomHex
}
let
(
:project_path
)
{
'test-project-name'
+
randomHex
}
context
'prefilled the path'
do
context
'prefilled the path'
do
it
'user imports an exported project successfully'
do
it
'user imports an exported project successfully'
do
...
@@ -30,7 +31,6 @@ describe 'Import/Export - project import integration test', :js do
...
@@ -30,7 +31,6 @@ describe 'Import/Export - project import integration test', :js do
select2
(
namespace
.
id
,
from:
'#project_namespace_id'
)
select2
(
namespace
.
id
,
from:
'#project_namespace_id'
)
fill_in
:project_name
,
with:
project_name
,
visible:
true
fill_in
:project_name
,
with:
project_name
,
visible:
true
fill_in
:project_path
,
with:
project_path
,
visible:
true
click_import_project_tab
click_import_project_tab
click_link
'GitLab export'
click_link
'GitLab export'
...
@@ -79,7 +79,6 @@ describe 'Import/Export - project import integration test', :js do
...
@@ -79,7 +79,6 @@ describe 'Import/Export - project import integration test', :js do
select2
(
user
.
namespace
.
id
,
from:
'#project_namespace_id'
)
select2
(
user
.
namespace
.
id
,
from:
'#project_namespace_id'
)
fill_in
:project_name
,
with:
project
.
name
,
visible:
true
fill_in
:project_name
,
with:
project
.
name
,
visible:
true
fill_in
:project_path
,
with:
project
.
path
,
visible:
true
click_import_project_tab
click_import_project_tab
click_link
'GitLab export'
click_link
'GitLab export'
attach_file
(
'file'
,
file
)
attach_file
(
'file'
,
file
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment