Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
63d220f2
Commit
63d220f2
authored
Feb 01, 2019
by
Semyon Pupkov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix ReturnInVoidContext rubocop offense
parent
9a0dd375
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
10 deletions
+7
-10
.rubocop_todo.yml
.rubocop_todo.yml
+0
-5
app/models/project.rb
app/models/project.rb
+7
-5
No files found.
.rubocop_todo.yml
View file @
63d220f2
...
...
@@ -80,11 +80,6 @@ Lint/InterpolationCheck:
Lint/MissingCopEnableDirective
:
Enabled
:
false
# Offense count: 1
Lint/ReturnInVoidContext
:
Exclude
:
-
'
app/models/project.rb'
# Offense count: 9
Lint/UriEscapeUnescape
:
Exclude
:
...
...
app/models/project.rb
View file @
63d220f2
...
...
@@ -738,11 +738,13 @@ class Project < ActiveRecord::Base
end
def
import_url
=
(
value
)
return
super
(
value
)
unless
Gitlab
::
UrlSanitizer
.
valid?
(
value
)
if
Gitlab
::
UrlSanitizer
.
valid?
(
value
)
import_url
=
Gitlab
::
UrlSanitizer
.
new
(
value
)
super
(
import_url
.
sanitized_url
)
create_or_update_import_data
(
credentials:
import_url
.
credentials
)
else
super
(
value
)
end
end
def
import_url
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment