Merge branch '27966-branch-ref-switcher-input-filter-broken' into 'master'

Display loading indicator when filtering ref switcher dropdown

Closes #27966

See merge request !9144

app/assets/javascripts/gl_dropdown.js

@@ -47,9 +47,11 @@
           }
           // Only filter asynchronously only if option remote is set
           if (this.options.remote) {
+            $inputContainer.parent().addClass('is-loading');
             clearTimeout(timeout);
             return timeout = setTimeout(function() {
               return this.options.query(this.input.val(), function(data) {
+                $inputContainer.parent().removeClass('is-loading');
                 return this.options.callback(data);
               }.bind(this));
             }.bind(this), 250);

changelogs/unreleased/27966-branch-ref-switcher-input-filter-broken.yml

+---
+title: Display loading indicator when filtering ref switcher dropdown
+merge_request:
+author:

spec/features/projects/ref_switcher_spec.rb

@@ -20,10 +20,10 @@ feature 'Ref switcher', feature: true, js: true do
       input.set 'binary'
       wait_for_ajax
 
-      input.native.send_keys :down
-      input.native.send_keys :down
+      page.within '.dropdown-content ul' do
         input.native.send_keys :enter
       end
+    end
 
     expect(page).to have_title 'binary-encoding'
   end

spec/javascripts/gl_dropdown_spec.js.es6

@@ -139,6 +139,14 @@ require('~/lib/utils/url_utility');
         this.dropdownButtonElement.click();
       });
 
+      it('should show loading indicator while search results are being fetched by backend', () => {
+        const dropdownMenu = document.querySelector('.dropdown-menu');
+
+        expect(dropdownMenu.className.indexOf('is-loading') !== -1).toEqual(true);
+        remoteCallback();
+        expect(dropdownMenu.className.indexOf('is-loading') !== -1).toEqual(false);
+      });
+
       it('should not focus search input while remote task is not complete', () => {
         expect($(document.activeElement)).not.toEqual($(SEARCH_INPUT_SELECTOR));
         remoteCallback();