Commit 803671cc authored by Sean McGivern's avatar Sean McGivern

Remove confidential access checks if user has group access

We simplify the query generated if the user can see all confidential issues in a
project context. This change applies the same simplification to group issue
lists.
parent b480d712
...@@ -120,9 +120,13 @@ class IssuesFinder < IssuableFinder ...@@ -120,9 +120,13 @@ class IssuesFinder < IssuableFinder
return @user_can_see_all_confidential_issues = true if current_user.full_private_access? return @user_can_see_all_confidential_issues = true if current_user.full_private_access?
@user_can_see_all_confidential_issues = @user_can_see_all_confidential_issues =
project? && if project? && project
project && project.team.max_member_access(current_user.id) >= CONFIDENTIAL_ACCESS_LEVEL
project.team.max_member_access(current_user.id) >= CONFIDENTIAL_ACCESS_LEVEL elsif group
group.max_member_access_for_user(current_user) >= CONFIDENTIAL_ACCESS_LEVEL
else
false
end
end end
def user_cannot_see_confidential_issues? def user_cannot_see_confidential_issues?
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment