Merge branch 'fix-latest-pipeine-ordering-again' into 'master'

Order only for latest_successful_for

See merge request !8301

app/models/ci/pipeline.rb

@@ -102,7 +102,7 @@ module Ci
     end
 
     def self.latest_successful_for(ref)
-      success.latest(ref).first
+      success.latest(ref).order(id: :desc).first
     end
 
     def self.truncate_sha(sha)

changelogs/unreleased/fix-latest-pipeine-ordering.yml

 ---
 title: Fix finding the latest pipeline
-merge_request: 8286
+merge_request: 8301
 author:

spec/models/ci/pipeline_spec.rb

@@ -462,6 +462,19 @@ describe Ci::Pipeline, models: true do
     end
   end
 
+  describe '.latest_successful_for' do
+    include_context 'with some outdated pipelines'
+
+    let!(:latest_successful_pipeline) do
+      create_pipeline(:success, 'ref', 'D')
+    end
+
+    it 'returns the latest successful pipeline' do
+      expect(described_class.latest_successful_for('ref')).
+        to eq(latest_successful_pipeline)
+    end
+  end
+
   describe '#status' do
     let!(:build) { create(:ci_build, :created, pipeline: pipeline, name: 'test') }