Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
a5bd978a
Commit
a5bd978a
authored
Jun 27, 2018
by
Jasper Maes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rails5 fix Mysql comparison failure caused by milliseconds problem
parent
07de43a7
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
3 deletions
+15
-3
changelogs/unreleased/rails5-fix-48432.yml
changelogs/unreleased/rails5-fix-48432.yml
+5
-0
spec/models/concerns/resolvable_discussion_spec.rb
spec/models/concerns/resolvable_discussion_spec.rb
+10
-3
No files found.
changelogs/unreleased/rails5-fix-48432.yml
0 → 100644
View file @
a5bd978a
---
title
:
Rails5 fix Mysql comparison failure caused by milliseconds problem
merge_request
:
20222
author
:
Jasper Maes
type
:
fixed
spec/models/concerns/resolvable_discussion_spec.rb
View file @
a5bd978a
...
@@ -534,11 +534,18 @@ describe Discussion, ResolvableDiscussion do
...
@@ -534,11 +534,18 @@ describe Discussion, ResolvableDiscussion do
describe
"#last_resolved_note"
do
describe
"#last_resolved_note"
do
let
(
:current_user
)
{
create
(
:user
)
}
let
(
:current_user
)
{
create
(
:user
)
}
let
(
:time
)
{
Time
.
now
.
utc
}
before
do
before
do
first_note
.
resolve!
(
current_user
)
Timecop
.
freeze
(
time
-
1
.
second
)
do
third_note
.
resolve!
(
current_user
)
first_note
.
resolve!
(
current_user
)
second_note
.
resolve!
(
current_user
)
end
Timecop
.
freeze
(
time
)
do
third_note
.
resolve!
(
current_user
)
end
Timecop
.
freeze
(
time
+
1
.
second
)
do
second_note
.
resolve!
(
current_user
)
end
end
end
it
"returns the last note that was resolved"
do
it
"returns the last note that was resolved"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment