Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
b7b49c4a
Commit
b7b49c4a
authored
7 years ago
by
Mike Greiling
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
prefer !x.exists? instead of x.none? to prevent unnecessary instantiation of records
parent
1c3b3fac
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
2 deletions
+2
-2
app/models/group.rb
app/models/group.rb
+2
-2
No files found.
app/models/group.rb
View file @
b7b49c4a
...
...
@@ -129,11 +129,11 @@ class Group < Namespace
end
def
visibility_level_allowed_by_projects?
(
level
=
self
.
visibility_level
)
projects
.
where
(
'visibility_level > ?'
,
level
).
none
?
!
projects
.
where
(
'visibility_level > ?'
,
level
).
exists
?
end
def
visibility_level_allowed_by_sub_groups?
(
level
=
self
.
visibility_level
)
children
.
where
(
'visibility_level > ?'
,
level
).
none
?
!
children
.
where
(
'visibility_level > ?'
,
level
).
exists
?
end
def
visibility_level_allowed?
(
level
=
self
.
visibility_level
)
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment