Add more tests to Projects::Clusters::ApplicationsController

app/controllers/projects/clusters/applications_controller.rb

@@ -5,15 +5,13 @@ class Projects::Clusters::ApplicationsController < Projects::ApplicationControll
   before_action :authorize_create_cluster!, only: [:create]
 
   def create
-    scheduled = Clusters::Applications::ScheduleInstallationService.new(project, current_user,
+    Clusters::Applications::ScheduleInstallationService.new(project, current_user,
                                                             application_class: @application_class,
                                                             cluster: @cluster).execute
-    if scheduled
     head :no_content
-    else
+  rescue StandardError
     head :bad_request
   end
-  end
 
   private
 

spec/controllers/projects/clusters/applications_controller_spec.rb

@@ -49,6 +49,19 @@ describe Projects::Clusters::ApplicationsController do
           expect(response).to have_http_status(:not_found)
         end
       end
+
+      context 'when application is already installing' do
+        before do
+          other = current_application.new(cluster: cluster)
+          other.make_installing!
+        end
+
+        it 'returns 400' do
+          go
+
+          expect(response).to have_http_status(:bad_request)
+        end
+      end
     end
 
     describe 'security' do