Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
fed9dcd9
Commit
fed9dcd9
authored
Apr 20, 2017
by
Douwe Maan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add test stubs
parent
0cfb3819
Changes
8
Hide whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
33 additions
and
193 deletions
+33
-193
app/models/blob.rb
app/models/blob.rb
+2
-2
spec/controllers/concerns/renders_blob_spec.rb
spec/controllers/concerns/renders_blob_spec.rb
+5
-0
spec/models/blob_spec.rb
spec/models/blob_spec.rb
+1
-191
spec/models/blob_viewer/base_spec.rb
spec/models/blob_viewer/base_spec.rb
+5
-0
spec/views/projects/blob/_render_error.html.haml_spec.rb
spec/views/projects/blob/_render_error.html.haml_spec.rb
+5
-0
spec/views/projects/blob/_viewer.html.haml_spoc.rb
spec/views/projects/blob/_viewer.html.haml_spoc.rb
+5
-0
spec/views/projects/blob/_viewer_switcher.html.haml_spoc.rb
spec/views/projects/blob/_viewer_switcher.html.haml_spoc.rb
+5
-0
spec/views/projects/blob/_viewer_wrapper.html.haml_spoc.rb
spec/views/projects/blob/_viewer_wrapper.html.haml_spoc.rb
+5
-0
No files found.
app/models/blob.rb
View file @
fed9dcd9
...
@@ -28,13 +28,13 @@ class Blob < SimpleDelegator
...
@@ -28,13 +28,13 @@ class Blob < SimpleDelegator
#
#
# blob = Blob.decorate(nil)
# blob = Blob.decorate(nil)
# puts "truthy" if blob # No output
# puts "truthy" if blob # No output
def
self
.
decorate
(
blob
,
project
)
def
self
.
decorate
(
blob
,
project
=
nil
)
return
if
blob
.
nil?
return
if
blob
.
nil?
new
(
blob
,
project
)
new
(
blob
,
project
)
end
end
def
initialize
(
blob
,
project
)
def
initialize
(
blob
,
project
=
nil
)
@project
=
project
@project
=
project
super
(
blob
)
super
(
blob
)
...
...
spec/controllers/concerns/renders_blob_spec.rb
0 → 100644
View file @
fed9dcd9
include
'spec_helper'
describe
Projects
::
BlobController
,
RendersBlob
,
model:
true
do
# TODO: Test
end
spec/models/blob_spec.rb
View file @
fed9dcd9
...
@@ -27,195 +27,5 @@ describe Blob do
...
@@ -27,195 +27,5 @@ describe Blob do
end
end
end
end
describe
'#svg?'
do
# TODO: Test new methods
it
'is falsey when not text'
do
git_blob
=
double
(
text?:
false
)
expect
(
described_class
.
decorate
(
git_blob
)).
not_to
be_svg
end
it
'is falsey when no language is detected'
do
git_blob
=
double
(
text?:
true
,
language:
nil
)
expect
(
described_class
.
decorate
(
git_blob
)).
not_to
be_svg
end
it
' is falsey when language is not SVG'
do
git_blob
=
double
(
text?:
true
,
language:
double
(
name:
'XML'
))
expect
(
described_class
.
decorate
(
git_blob
)).
not_to
be_svg
end
it
'is truthy when language is SVG'
do
git_blob
=
double
(
text?:
true
,
language:
double
(
name:
'SVG'
))
expect
(
described_class
.
decorate
(
git_blob
)).
to
be_svg
end
end
describe
'#pdf?'
do
it
'is falsey when file extension is not .pdf'
do
git_blob
=
Gitlab
::
Git
::
Blob
.
new
(
name:
'git_blob.txt'
)
expect
(
described_class
.
decorate
(
git_blob
)).
not_to
be_pdf
end
it
'is truthy when file extension is .pdf'
do
git_blob
=
Gitlab
::
Git
::
Blob
.
new
(
name:
'git_blob.pdf'
)
expect
(
described_class
.
decorate
(
git_blob
)).
to
be_pdf
end
end
describe
'#ipython_notebook?'
do
it
'is falsey when language is not Jupyter Notebook'
do
git_blob
=
double
(
text?:
true
,
language:
double
(
name:
'JSON'
))
expect
(
described_class
.
decorate
(
git_blob
)).
not_to
be_ipython_notebook
end
it
'is truthy when language is Jupyter Notebook'
do
git_blob
=
double
(
text?:
true
,
language:
double
(
name:
'Jupyter Notebook'
))
expect
(
described_class
.
decorate
(
git_blob
)).
to
be_ipython_notebook
end
end
describe
'#sketch?'
do
it
'is falsey with image extension'
do
git_blob
=
Gitlab
::
Git
::
Blob
.
new
(
name:
"design.png"
)
expect
(
described_class
.
decorate
(
git_blob
)).
not_to
be_sketch
end
it
'is truthy with sketch extension'
do
git_blob
=
Gitlab
::
Git
::
Blob
.
new
(
name:
"design.sketch"
)
expect
(
described_class
.
decorate
(
git_blob
)).
to
be_sketch
end
end
describe
'#video?'
do
it
'is falsey with image extension'
do
git_blob
=
Gitlab
::
Git
::
Blob
.
new
(
name:
'image.png'
)
expect
(
described_class
.
decorate
(
git_blob
)).
not_to
be_video
end
UploaderHelper
::
VIDEO_EXT
.
each
do
|
ext
|
it
"is truthy when extension is .
#{
ext
}
"
do
git_blob
=
Gitlab
::
Git
::
Blob
.
new
(
name:
"video.
#{
ext
}
"
)
expect
(
described_class
.
decorate
(
git_blob
)).
to
be_video
end
end
end
describe
'#stl?'
do
it
'is falsey with image extension'
do
git_blob
=
Gitlab
::
Git
::
Blob
.
new
(
name:
'file.png'
)
expect
(
described_class
.
decorate
(
git_blob
)).
not_to
be_stl
end
it
'is truthy with STL extension'
do
git_blob
=
Gitlab
::
Git
::
Blob
.
new
(
name:
'file.stl'
)
expect
(
described_class
.
decorate
(
git_blob
)).
to
be_stl
end
end
describe
'#to_partial_path'
do
let
(
:project
)
{
double
(
lfs_enabled?:
true
)
}
def
stubbed_blob
(
overrides
=
{})
overrides
.
reverse_merge!
(
name:
nil
,
image?:
false
,
language:
nil
,
lfs_pointer?:
false
,
svg?:
false
,
text?:
false
,
binary?:
false
,
stl?:
false
)
described_class
.
decorate
(
Gitlab
::
Git
::
Blob
.
new
({})).
tap
do
|
blob
|
allow
(
blob
).
to
receive_messages
(
overrides
)
end
end
it
'handles LFS pointers with LFS enabled'
do
blob
=
stubbed_blob
(
lfs_pointer?:
true
,
text?:
true
)
expect
(
blob
.
to_partial_path
(
project
)).
to
eq
'download'
end
it
'handles LFS pointers with LFS disabled'
do
blob
=
stubbed_blob
(
lfs_pointer?:
true
,
text?:
true
)
project
=
double
(
lfs_enabled?:
false
)
expect
(
blob
.
to_partial_path
(
project
)).
to
eq
'text'
end
it
'handles SVGs'
do
blob
=
stubbed_blob
(
text?:
true
,
svg?:
true
)
expect
(
blob
.
to_partial_path
(
project
)).
to
eq
'svg'
end
it
'handles images'
do
blob
=
stubbed_blob
(
image?:
true
)
expect
(
blob
.
to_partial_path
(
project
)).
to
eq
'image'
end
it
'handles text'
do
blob
=
stubbed_blob
(
text?:
true
,
name:
'test.txt'
)
expect
(
blob
.
to_partial_path
(
project
)).
to
eq
'text'
end
it
'defaults to download'
do
blob
=
stubbed_blob
expect
(
blob
.
to_partial_path
(
project
)).
to
eq
'download'
end
it
'handles PDFs'
do
blob
=
stubbed_blob
(
name:
'blob.pdf'
,
pdf?:
true
)
expect
(
blob
.
to_partial_path
(
project
)).
to
eq
'pdf'
end
it
'handles iPython notebooks'
do
blob
=
stubbed_blob
(
text?:
true
,
ipython_notebook?:
true
)
expect
(
blob
.
to_partial_path
(
project
)).
to
eq
'notebook'
end
it
'handles Sketch files'
do
blob
=
stubbed_blob
(
text?:
true
,
sketch?:
true
,
binary?:
true
)
expect
(
blob
.
to_partial_path
(
project
)).
to
eq
'sketch'
end
it
'handles STLs'
do
blob
=
stubbed_blob
(
text?:
true
,
stl?:
true
)
expect
(
blob
.
to_partial_path
(
project
)).
to
eq
'stl'
end
end
describe
'#size_within_svg_limits?'
do
let
(
:blob
)
{
described_class
.
decorate
(
double
(
:blob
))
}
it
'returns true when the blob size is smaller than the SVG limit'
do
expect
(
blob
).
to
receive
(
:size
).
and_return
(
42
)
expect
(
blob
.
size_within_svg_limits?
).
to
eq
(
true
)
end
it
'returns true when the blob size is equal to the SVG limit'
do
expect
(
blob
).
to
receive
(
:size
).
and_return
(
Blob
::
MAXIMUM_SVG_SIZE
)
expect
(
blob
.
size_within_svg_limits?
).
to
eq
(
true
)
end
it
'returns false when the blob size is larger than the SVG limit'
do
expect
(
blob
).
to
receive
(
:size
).
and_return
(
1
.
terabyte
)
expect
(
blob
.
size_within_svg_limits?
).
to
eq
(
false
)
end
end
end
end
spec/models/blob_viewer/base_spec.rb
0 → 100644
View file @
fed9dcd9
include
'spec_helper'
describe
BlobViewer
::
Base
,
model:
true
do
# TODO: Test
end
spec/views/projects/blob/_render_error.html.haml_spec.rb
0 → 100644
View file @
fed9dcd9
require
'spec_helper'
describe
'app/views/projects/blob/_render_error.html.haml'
do
# TODO: Test
end
spec/views/projects/blob/_viewer.html.haml_spoc.rb
0 → 100644
View file @
fed9dcd9
require
'spec_helper'
describe
'app/views/projects/blob/_viewer.html.haml'
do
# TODO: Test
end
spec/views/projects/blob/_viewer_switcher.html.haml_spoc.rb
0 → 100644
View file @
fed9dcd9
require
'spec_helper'
describe
'app/views/projects/blob/_viewer_switcher.html.haml'
do
# TODO: Test
end
spec/views/projects/blob/_viewer_wrapper.html.haml_spoc.rb
0 → 100644
View file @
fed9dcd9
require
'spec_helper'
describe
'app/views/projects/blob/_viewer_wrapper.html.haml'
do
# TODO: Test
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment