Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
erp5
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Analytics
Analytics
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
Lu Xu
erp5
Commits
ccd340d4
Commit
ccd340d4
authored
Mar 04, 2013
by
Vincent Pelletier
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Improve comment.
parent
31917c18
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
13 additions
and
4 deletions
+13
-4
product/ERP5/Tool/SimulationTool.py
product/ERP5/Tool/SimulationTool.py
+13
-4
No files found.
product/ERP5/Tool/SimulationTool.py
View file @
ccd340d4
...
...
@@ -1568,10 +1568,19 @@ class SimulationTool(BaseTool):
elif
line_a
[
key
]
==
line_b
[
key
]:
result
[
key
]
=
line_a
[
key
]
elif
key
not
in
(
'date'
,
'stock_uid'
,
'path'
):
# This case happens when we got columns in result
# which are not part of the group by statement, MySQL
# used to choose randomly a value for this column, here
# we just do not set the key in result returned
# There are 2 possible reasons to end up here:
# - key corresponds to a projected column for which are neither
# known aggregated columns (in which case they should be in
# result_column_id_dict) nor part of grouping columns, and the
# result happens to be unstable. There are cases in ERP5 where
# such result is suposed to be stable, for example
# group_by=('xxx_uid'), selection_list=('xxx_path') because the
# relation is bijective (although the database doesn't know it).
# These should result in stable results (but don't necessarily
# do, ex: xxx_title when object title has been changed between
# cache fill and cache lookup).
# - line_a and line_b are indeed mismatched, and code calling us
# has a bug.
LOG
(
'InventoryTool.getInventoryList.addLineValues'
,
PROBLEM
,
'mismatch for %s column: %s and %s'
%
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment