From 24ef9034f850812007b97304f09400f1f7392afc Mon Sep 17 00:00:00 2001
From: Romain Courteaud <romain@nexedi.com>
Date: Thu, 1 Feb 2007 13:08:12 +0000
Subject: [PATCH] Compute solver_script_list only once.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@12500 20353a03-c40f-0410-a6d1-a30d3c3de9de
---
 .../ERP5/Document/PropertyDivergenceTester.py    | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/product/ERP5/Document/PropertyDivergenceTester.py b/product/ERP5/Document/PropertyDivergenceTester.py
index 7b203105cf..b4171f464e 100644
--- a/product/ERP5/Document/PropertyDivergenceTester.py
+++ b/product/ERP5/Document/PropertyDivergenceTester.py
@@ -75,6 +75,13 @@ class PropertyDivergenceTester(XMLObject):
     """
     divergence_message_list = []
     tested_property = self.getTestedPropertyList()     
+
+    # Get the list of solvers callable in this case
+    solver_script_list = self.getSolverScriptList()
+    if solver_script_list is None:
+      solver_script_list = [] 
+    solver_script_list = self._splitStringList(solver_script_list)
+
     for tested_property_id, tested_property_title in \
                        self._splitStringList(tested_property):
       
@@ -82,12 +89,7 @@ class PropertyDivergenceTester(XMLObject):
       delivery_mvt_property = delivery_mvt.getProperty(tested_property_id)
       simulation_mvt_property = simulation_movement.getProperty(tested_property_id)
       
-      message = None
- 
       if delivery_mvt_property != simulation_mvt_property:
-        solver_script_list = self.getSolverScriptList()
-        if solver_script_list is None:
-          solver_script_list = [] 
         message = ObjectMessage(
                    object_relative_url=delivery_mvt.getRelativeUrl(),
                    simulation_movement=simulation_movement,
@@ -95,8 +97,8 @@ class PropertyDivergenceTester(XMLObject):
                    prevision_value=simulation_mvt_property,
                    tested_property=tested_property_id,
                    message=tested_property_title,
-                   solver_script_list=self._splitStringList(solver_script_list)
-                   )
+                   solver_script_list=solver_script_list
+        )
         divergence_message_list.append(message)  
     
     return divergence_message_list
-- 
2.30.9