Commits · 56d5c41fa3f3148b6afb4706fa80fead0e232eb2 · mirror / ccan

01 Dec, 2020 1 commit
- utf8: don't allow NUL in decoded strings. · 56d5c41f
  Rusty Russell authored Dec 01, 2020
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  56d5c41f
14 Sep, 2020 1 commit

json_out: make json_out_finished finish buffer. · b45a3266

Rusty Russell authored Sep 14, 2020

For JSON RPC, we can actually write multiple JSON objects back
to back, and we don't want a comma between them.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

b45a3266

11 Sep, 2020 1 commit

*: Fix build with recent gcc/binutils · b97c7f08

Kirill Smelkov authored Sep 10, 2020

With current Debian testing I get:

	tools/ccanlint/ccanlint -s --deps-fail-ignore   ccan/compiler/ && touch ccan/compiler/.ok
	compiler: Module tests compile (tests_compile): FAIL
	/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/ccan/compiler/test/run-is_compile_constant.c:Compile failed:
	/usr/bin/ld: /tmp/ccanlint-129350.1804289383/tap.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/ccan/tap/tap.h:249: multiple definition of `tap_fail_callback'; /tmp/ccrAwqbl.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/ccan/tap/tap.h:249: first defined here
	collect2: error: ld returned 1 exit status
	...

	cc -g3 -ggdb -Wall -Wstrict-prototypes -Wold-style-definition -Wundef -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -DCCAN_STR_DEBUG=1 -I.  -MMD -MP -MFtools/ccanlint/ccanlint.d -MTtools/ccanlint/ccanlint tools/ccanlint/ccanlint.c tools/ccanlint/async.o tools/ccanlint/file_analysis.o tools/ccanlint/licenses.o tools/ccanlint/tests/avoids_cpp_reserved.o tools/ccanlint/tests/depends_accurate.o tools/ccanlint/tests/depends_build.o tools/ccanlint/tests/depends_build_without_features.o tools/ccanlint/tests/depends_exist.o tools/ccanlint/tests/examples_compile.o tools/ccanlint/tests/examples_exist.o tools/ccanlint/tests/examples_relevant.o tools/ccanlint/tests/examples_run.o tools/ccanlint/tests/hash_if.o tools/ccanlint/tests/headers_idempotent.o tools/ccanlint/tests/info_compiles.o tools/ccanlint/tests/info_documentation_exists.o tools/ccanlint/tests/info_exists.o tools/ccanlint/tests/info_ported.o tools/ccanlint/tests/info_summary_single_line.o tools/ccanlin
 t/tests/license_comment.o tools/ccanlint/tests/license_depends_compat.o tools/ccanlint/tests/license_exists.o tools/ccanlint/tests/license_file_compat.o tools/ccanlint/tests/main_header_compiles.o tools/ccanlint/tests/main_header_exists.o tools/ccanlint/tests/module_builds.o tools/ccanlint/tests/module_links.o tools/ccanlint/tests/no_trailing_whitespace.o tools/ccanlint/tests/objects_build.o tools/ccanlint/tests/objects_build_with_stringchecks.o tools/ccanlint/tests/objects_build_without_features.o tools/ccanlint/tests/reduce_features.o tools/ccanlint/tests/tests_compile.o tools/ccanlint/tests/tests_compile_coverage.o tools/ccanlint/tests/tests_coverage.o tools/ccanlint/tests/tests_exist.o tools/ccanlint/tests/tests_helpers_compile.o tools/ccanlint/tests/tests_pass.o tools/ccanlint/tests/tests_pass_valgrind.o tools/ccanlint/tests/tests_pass_without_features.o ccan/autodata/autodata.o ccan/dgraph/dgraph.o ccan/ilog/ilog.o ccan/lbalance/lbalance.o ccan/ptr_valid/ptr_valid.o ccan/strma
 p/strmap.o tools/ccan_dir.o tools/compi
	le.o tools/depends.o tools/doc_extract-core.o tools/gcov.o tools/manifest.o tools/read_config_header.o tools/tools.o ccan/asort/asort.o ccan/err/err.o ccan/foreach/foreach.o ccan/hash/hash.o ccan/htable/htable.o ccan/list/list.o ccan/membuf/membuf.o ccan/noerr/noerr.o ccan/opt/helpers.o ccan/opt/opt.o ccan/opt/parse.o ccan/opt/usage.o ccan/rbuf/rbuf.o ccan/read_write_all/read_write_all.o ccan/str/debug.o ccan/str/str.o ccan/take/take.o ccan/tal/tal.o ccan/tal/grab_file/grab_file.o ccan/tal/link/link.o ccan/tal/path/path.o ccan/tal/str/str.o ccan/time/time.o -lm -o tools/ccanlint/ccanlint
	/usr/bin/ld: tools/ccanlint/async.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/tools/ccanlint/../ccanlint/licenses.h:33: multiple definition of `license_compatible'; /tmp/cc72h7qq.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/tools/ccanlint/../ccanlint/licenses.h:33: first defined here
	/usr/bin/ld: tools/ccanlint/file_analysis.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/tools/ccanlint/../ccanlint/licenses.h:33: multiple definition of `license_compatible'; /tmp/cc72h7qq.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/tools/ccanlint/../ccanlint/licenses.h:33: first defined here
	/usr/bin/ld: tools/ccanlint/licenses.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/tools/ccanlint/licenses.h:33: multiple definition of `license_compatible'; /tmp/cc72h7qq.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/tools/ccanlint/../ccanlint/licenses.h:33: first defined here
	/usr/bin/ld: tools/ccanlint/tests/avoids_cpp_reserved.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/./tools/ccanlint/../ccanlint/licenses.h:33: multiple definition of `license_compatible'; /tmp/cc72h7qq.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/tools/ccanlint/../ccanlint/licenses.h:33: first defined
	here
	/usr/bin/ld: tools/ccanlint/tests/depends_accurate.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/./tools/ccanlint/../ccanlint/licenses.h:33: multiple definition of `license_compatible'; /tmp/cc72h7qq.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/tools/ccanlint/../ccanlint/licenses.h:33: first defined here
	/usr/bin/ld: tools/ccanlint/tests/depends_build.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/./tools/ccanlint/../ccanlint/licenses.h:33: multiple definition of `license_compatible'; /tmp/cc72h7qq.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/tools/ccanlint/../ccanlint/licenses.h:33: first defined here
	/usr/bin/ld: tools/ccanlint/tests/depends_build_without_features.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/./tools/ccanlint/../ccanlint/licenses.h:33: multiple definition of `license_compatible'; /tmp/cc72h7qq.o:/home/kirr/src/wendelin/wendelin.core/3rdparty/ccan/tools/ccanlint/../ccanlint/licenses.h:33: first defined here
	...

The errors are valid becuase symbols are declared without extern in .h
files and those .h files are included from multiple translation units.

-> Fix it. I'm not sure why it used to compile ok before.
Signed-off-by: Kirill Smelkov <kirr@nexedi.com>
Message-Id: <20200910191610.131510-1-kirr@nexedi.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

b97c7f08

17 Jul, 2020 1 commit

tools/configurator: fix compile error with -O2 · cbc7cbf1

Rusty Russell authored Jul 17, 2020

In file included from /usr/include/string.h:495,
                 from configuratortest.c:2:
In function ‘strncpy’,
    inlined from ‘main’ at configuratortest.c:6:2:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ specified bound 8 equals destination size [-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

cbc7cbf1

19 Jun, 2020 1 commit
- tal: document tal_steal(ctx, NULL) as OK. · fc339122
  Rusty Russell authored Jun 19, 2020
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  fc339122
20 Feb, 2020 2 commits
- htable: add htable_type _delval. · 57a1b0f3
  Rusty Russell authored Feb 20, 2020
```
To match the raw delval
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  57a1b0f3
- htable: fix type of htable_type _pick return. · 1cebc089
  Rusty Russell authored Feb 20, 2020
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  1cebc089
19 Feb, 2020 1 commit
- htable: htable_pick helper to select a random entry. · 209a8190
  Rusty Russell authored Feb 20, 2020
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  209a8190
17 Feb, 2020 1 commit

tal: don't defer-after-free if a destructor deletes itself. · c910bdce

Rusty Russell authored Feb 17, 2020

==10868==    at 0x109A96: notify (tal.c:220)
==10868==    by 0x109F7E: del_tree (tal.c:397)
==10868==    by 0x10A31A: tal_free (tal.c:481)
==10868==    by 0x10BE73: main (run-destructor.c:75)
==10868==  Address 0x4a60bd8 is 8 bytes inside a block of size 32 free'd
==10868==    at 0x483BA3F: free (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==10868==    by 0x109D4F: del_notifier_property (tal.c:340)
==10868==    by 0x10A610: tal_del_notifier_ (tal.c:564)
==10868==    by 0x10A687: tal_del_destructor_ (tal.c:576)
==10868==    by 0x10B653: remove_own_destructor (run-destructor.c:35)
==10868==    by 0x109A67: notify (tal.c:235)
==10868==    by 0x109F7E: del_tree (tal.c:397)
==10868==    by 0x10A31A: tal_free (tal.c:481)
==10868==    by 0x10BE73: main (run-destructor.c:75)
==10868==  Block was alloc'd at
==10868==    at 0x483A7F3: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==10868==    by 0x109AD5: allocate (tal.c:245)
==10868==    by 0x109C3E: add_notifier_property (tal.c:300)
==10868==    by 0x10A467: tal_add_destructor_ (tal.c:516)
==10868==    by 0x10BDFE: main (run-destructor.c:74)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

c910bdce

11 Feb, 2020 1 commit

opt: fix opt_unregister. · 4f20b75c

Rusty Russell authored Feb 11, 2020

Instead of memmoving N structs, we were memmoving N bytes.

But why did the test pass then?  It was doing memmove(..., 1)
instead of memmove(..., sizeof(struct opt_table)!

Because the two structures were really similar; the main difference
was the first entry, which points to the name.  But they were allocated
consecutively, and Intel being little-endian, the only difference was
the first byte!  Thus memmove(1) was enough to make it "work".

Change two options in the test to be sufficiently different, and
the bug shows up.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

4f20b75c

04 Feb, 2020 4 commits

xtea: new module. · e5fb923b
Rusty Russell authored Feb 04, 2020
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
e5fb923b

opt: add opt_unregister. · c36444e0

Rusty Russell authored Feb 04, 2020

Sometimes we all make mistakes.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

c36444e0

tools/configurator: simplify wrapper code a little. · a1f9c169
Rusty Russell authored Feb 04, 2020
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
a1f9c169

configurator: Enable running configurator in wrapper · 42d7b648

Niklas Claesson authored Jan 29, 2020

Since the probing binaries compiled by the configurator needs to run on
the host machine we provide a variable CONFIGURATOR_WRAPPER that can be
set to anything that you want to wrap the calls with.

One example is `qemu-aarch64-static`.

42d7b648

22 Oct, 2019 1 commit

bitmap: Allow bitmap type to be forward declared · 39b46a02

Kirill Smelkov authored Oct 21, 2019

Currently bitmap type is defined via untagged struct which makes it
impossible to forward declare it. Forward-declaring is useful since all
bitmap functions only use bitmap* and in public user-visible
headers/datastructures it is enough to indicate that a data field with
bitmap pointer is there, whereas bitmap.h can be included only in
implementation.

Beside that some headers are included by both C and C++ parts of a
project, and when ccan/bitmap.h is processed by C++ compiler it gives:

    ./3rdparty/ccan/ccan/bitmap/bitmap.h: In function ‘bitmap* bitmap_alloc(long unsigned int)’:
    ./3rdparty/ccan/ccan/bitmap/bitmap.h:201:15: error: invalid conversion from ‘void*’ to ‘bitmap*’ [-fpermissive]
      return malloc(bitmap_sizeof(nbits));
             ~~~~~~^~~~~~~~~~~~~~~~~~~~~~
    ./3rdparty/ccan/ccan/bitmap/bitmap.h: In function ‘bitmap* bitmap_realloc0(bitmap*, long unsigned int, long unsigned int)’:
    ./3rdparty/ccan/ccan/bitmap/bitmap.h:227:18: error: invalid conversion from ‘void*’ to ‘bitmap*’ [-fpermissive]
      bitmap = realloc(bitmap, bitmap_sizeof(nbits));
               ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ./3rdparty/ccan/ccan/bitmap/bitmap.h: In function ‘bitmap* bitmap_realloc1(bitmap*, long unsigned int, long unsigned int)’:
    ./3rdparty/ccan/ccan/bitmap/bitmap.h:238:18: error: invalid conversion from ‘void*’ to ‘bitmap*’ [-fpermissive]
      bitmap = realloc(bitmap, bitmap_sizeof(nbits));

-> Give to users ability not to force-include ccan/bitmap.h by
forward-declaring bitmaps like this:

    typedef struct bitmap bitmap;
    ...
    struct MyStruct {
        bitmap *my_bitmap;
    };

Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Kirill Smelkov <kirr@nexedi.com>
Message-Id: <20191021150903.25159-1-kirr@nexedi.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

39b46a02

10 Oct, 2019 1 commit
- intmap: implement intmap_before() · 7aac849a
  Rusty Russell authored Oct 10, 2019
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  7aac849a
04 Oct, 2019 1 commit

failtest, rbuf: fix up incorrect lseek arg order. · f7ead5da

Rusty Russell authored Oct 04, 2019

SEEK_SET == 0, so it's not hurting anyone now, but when I cut & paste
it elsewhere...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

f7ead5da

14 Aug, 2019 1 commit

pipecmd: close fds in child. · 46cfc3ad

Rusty Russell authored Aug 14, 2019

This is usually what you want; I didn't even add a flag to stop it.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

46cfc3ad

13 Aug, 2019 1 commit
- htable: add htable_count(). · b98c6847
  Rusty Russell authored Aug 13, 2019
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  b98c6847
01 Aug, 2019 1 commit
- Suppress false positive warning "-Wmaybe-uninitialized" with GCC -O3 · e16aa40b
  Chirimen-Jako authored Jul 31, 2019
  
  e16aa40b
31 Jul, 2019 1 commit

configurator: fix openmp test on some versions of clang. · 920ca95d

Rusty Russell authored Jul 31, 2019

Discovered on bionic's Travis install, it failed at *runtime* when
it couldn't find the shared library.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

920ca95d

11 Jul, 2019 1 commit

bitmap: Fix some bugs on 32-bit platforms · cdd0b8b5

David Gibson authored Jul 11, 2019

The bitmap_word type is an unsigned long. However in some places we assign
it using -1ULL, a 64-bit value on many platforms. We sometimes get away
with this because it masks correctly, but in other cases it breaks things.

To clean this up define a new BITMAP_WORD_1 constant, indicating a
bitmap_word with all bits set, and use that instead of explicit UL or ULL
qualifiers.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

cdd0b8b5

11 Jun, 2019 4 commits

ccan/crc: remove broken "crc32c" routines which gave wrong results. · ce4660aa

Rusty Russell authored Jun 11, 2019

I copied them from the kernel, but obviously didn't find good test
vectors.  In particular, the CRC of all zeroes is not 0!
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

ce4660aa

ccan/crc32c: new module for accelerated CRC32 (on x86-64). · 2c148ec2

Rusty Russell authored Jun 11, 2019

Note: the previous code in ccan/crc is wrong, so I started fresh with
actual test vectors.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

2c148ec2

ccan/compiler: add cpu_supports() macro. · 2c77e8bd
Rusty Russell authored Jun 11, 2019
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
2c77e8bd
configurator: detect __builtin_cpu_supports. · 0bfaf906
Rusty Russell authored Jun 11, 2019
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
0bfaf906

23 May, 2019 1 commit

json_out: pass through OOM failures. · 4fc7da62

Rusty Russell authored May 23, 2019

And fix escaping to work with addstr(), and assert in debug mode
if they don't specify quotes.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

4fc7da62

22 May, 2019 1 commit
- json_out: new module for authoring JSON strings. · 2fd44331
  Rusty Russell authored May 21, 2019
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  2fd44331
21 May, 2019 2 commits
- json_escape: add fast-path for when we don't need to escape. · 3ceb24bf
  Rusty Russell authored May 21, 2019
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  3ceb24bf
- json_escape: new module to escape JSON strings. · 45f9ce17
  Rusty Russell authored May 21, 2019
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  45f9ce17
02 Apr, 2019 1 commit

htable: avoid branch in calculating perfect bit. · 7623d082

Rusty Russell authored Apr 02, 2019

Final results of tools/speed/10000000 (10 runs) shows a slight
slowdown in some tests, but it makes an empty htable smaller.

-Initial delete all: 96-98(96.4+/-0.66) ns
+Initial delete all: 97-99(98.2+/-0.75) ns
-Initial re-inserting: 117-124(121.4+/-1.9) ns
+Initial re-inserting: 124-131(126.4+/-2.4) ns
-Adding (a different) half: 49-50(49.3+/-0.46) ns
+Adding (a different) half: 50-52(51.2+/-0.75) ns
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

7623d082

01 Apr, 2019 2 commits
- htable: reduce size of htable by storing perfect bitnum, not mask. · d615e534
  Rusty Russell authored Apr 02, 2019
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  d615e534
- htable: reduce size of htable by calculating max every time. · 9e92552b
  Rusty Russell authored Apr 02, 2019
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  9e92552b
16 Mar, 2019 3 commits
- io: fix another leak path for always array. · 2b3517d4
  Rusty Russell authored Mar 16, 2019
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  2b3517d4
- io: don't leak memory on clean shutdown. · b089d462
  Rusty Russell authored Mar 16, 2019
```
Free the internal "always" array like we free "fds".
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  b089d462
- io: typo fixes. · bc6d22ec
  Rusty Russell authored Mar 16, 2019
```
Suggested-by: Lisa Neigut <@niftynei>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  bc6d22ec
04 Mar, 2019 4 commits
- htable: add allocator hooks. · 7a353c03
  Rusty Russell authored Mar 04, 2019
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  7a353c03
- htable: commit extra tests I had lying around. · 6a8bb209
  Rusty Russell authored Mar 04, 2019
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  6a8bb209
- timer: clean up hook allocator API · fe328d06
  Rusty Russell authored Mar 04, 2019
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  fe328d06
- timer: add hook for allocation functions. · 23e72d41
  Rusty Russell authored Mar 04, 2019
```
malloc and free aren't for everyone.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
  23e72d41