Commit 87b49138 authored by Jeremy Hylton's avatar Jeremy Hylton

Quick hack fix to these tests. XXX I don't really understand them.

The HoserStoppage and ExceptionInTpcFinish were failing intermittently
on Windows.  I assume the problem is that a single error in tpc_finish()
can be recovered from iff the error is for the first jar.  I assume that
most of the time the error occurred after some other jar had committed.
Fixed the test by causing two different jars to fail.
parent 695dd334
...@@ -14,7 +14,7 @@ ...@@ -14,7 +14,7 @@
""" """
Revision information: Revision information:
$Id: testTransaction.py,v 1.7 2002/04/15 18:55:11 jeremy Exp $ $Id: testTransaction.py,v 1.8 2002/08/12 20:00:49 jeremy Exp $
""" """
""" """
...@@ -360,10 +360,11 @@ class TransactionTests(unittest.TestCase): ...@@ -360,10 +360,11 @@ class TransactionTests(unittest.TestCase):
def testExceptionInTpcFinish(self): def testExceptionInTpcFinish(self):
self.sub1._p_jar = SubTransactionJar(errors='tpc_finish') for sub in self.sub1, self.sub2:
sub._p_jar = SubTransactionJar(errors='tpc_finish')
sub.modify(nojar=1)
self.nosub1.modify() self.nosub1.modify()
self.sub1.modify(nojar=1)
try: try:
get_transaction().commit() get_transaction().commit()
...@@ -543,10 +544,11 @@ class TransactionTests(unittest.TestCase): ...@@ -543,10 +544,11 @@ class TransactionTests(unittest.TestCase):
# last test, check the hosing mechanism # last test, check the hosing mechanism
def testHoserStoppage(self): def testHoserStoppage(self):
# must have errors in at least two jars to guarantee a failure
self.sub1._p_jar = SubTransactionJar(errors='tpc_finish') for sub in self.sub1, self.sub2:
sub._p_jar = SubTransactionJar(errors='tpc_finish')
sub.modify(nojar=1)
self.nosub1.modify() self.nosub1.modify()
self.sub1.modify(nojar=1)
try: try:
get_transaction().commit() get_transaction().commit()
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment