Commit f4869072 authored by Jeremy Hylton's avatar Jeremy Hylton

Yes. It should.

Move setLastTid() call into block where lock is held.
parent ed7e61bc
...@@ -960,12 +960,11 @@ class ClientStorage(object): ...@@ -960,12 +960,11 @@ class ClientStorage(object):
self._lock.acquire() # for atomic processing of invalidations self._lock.acquire() # for atomic processing of invalidations
try: try:
self._update_cache(tid) self._update_cache(tid)
self._cache.setLastTid(tid)
if f is not None: if f is not None:
f(tid) f(tid)
finally: finally:
self._lock.release() self._lock.release()
# XXX Shouldn't this cache call be made while holding the lock?
self._cache.setLastTid(tid)
r = self._check_serials() r = self._check_serials()
assert r is None or len(r) == 0, "unhandled serialnos: %s" % r assert r is None or len(r) == 0, "unhandled serialnos: %s" % r
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment