Commit aac4cd4b authored by Jim Fulton's avatar Jim Fulton

Bug Fixed: Packing failed for databases containing cross-database references.

parent 835eddf8
......@@ -5,6 +5,8 @@ Whats new in ZODB 3.8.1
Bugs Fixed:
- (beta 4) Packing failed for databases containing cross-database references.
- (beta 3) Cross-database references to databases with empty names
weren't constructed properly.
......
......@@ -605,17 +605,14 @@ class ObjectReader:
obj.__setstate__(state)
oid_loaders = {
'w': lambda oid: None,
}
def referencesf(p, oids=None):
"""Return a list of object ids found in a pickle
A list may be passed in, in which case, information is
appended to it.
Weak references are not included.
Only ordinary internal references are included.
Weak and multi-database references are not included.
"""
refs = []
......@@ -636,15 +633,9 @@ def referencesf(p, oids=None):
elif isinstance(reference, str):
oid = reference
else:
try:
reference_type, args = reference
except ValueError:
# weakref
assert isinstance(reference, list)
continue
else:
oid = oid_loaders[reference_type](*args)
if oid:
oids.append(oid)
return oids
......@@ -678,15 +669,9 @@ def get_refs(a_pickle):
elif isinstance(reference, str):
data = reference, None
else:
try:
reference_type, args = reference
except ValueError:
# weakref
assert isinstance(reference, list)
continue
else:
data = oid_klass_loaders[reference_type](*args)
if data:
result.append(data)
return result
......@@ -38,6 +38,8 @@ from ZODB.POSException import ConflictError, StorageError
from ZODB.tests.MTStorage import TestThread
import ZODB.tests.util
ZERO = '\0'*8
......@@ -311,6 +313,24 @@ class PackableStorage(PackableStorageBase):
pass
it.close()
def checkPackWithMultiDatabaseReferences(self):
databases = {}
db = DB(self._storage, databases=databases, database_name='')
otherdb = ZODB.tests.util.DB(databases=databases, database_name='o')
conn = db.open()
root = conn.root()
root[1] = C()
transaction.commit()
del root[1]
transaction.commit()
root[2] = conn.get_connection('o').root()
transaction.commit()
db.pack(time.time()+1)
assert(len(self._storage) == 1)
class PackableUndoStorage(PackableStorageBase):
def checkPackAllRevisions(self):
......@@ -705,3 +725,4 @@ class ElapsedTimer:
def elapsed_millis(self):
return int((time.time() - self.start_time) * 1000)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment