Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
B
babeld
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
babeld
Commits
a4fd3a8f
Commit
a4fd3a8f
authored
Sep 28, 2008
by
Juliusz Chroboczek
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use unsigned costs in neighbour_cost.
This avoids overflow by expanding the range.
parent
4d9d1080
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
3 deletions
+4
-3
neighbour.c
neighbour.c
+4
-3
No files found.
neighbour.c
View file @
a4fd3a8f
...
@@ -342,7 +342,7 @@ neighbour_rxcost(struct neighbour *neigh)
...
@@ -342,7 +342,7 @@ neighbour_rxcost(struct neighbour *neigh)
unsigned
unsigned
neighbour_cost
(
struct
neighbour
*
neigh
)
neighbour_cost
(
struct
neighbour
*
neigh
)
{
{
int
a
,
b
;
unsigned
a
,
b
;
if
(
!
neigh
->
network
->
up
)
if
(
!
neigh
->
network
->
up
)
return
INFINITY
;
return
INFINITY
;
...
@@ -364,7 +364,8 @@ neighbour_cost(struct neighbour *neigh)
...
@@ -364,7 +364,8 @@ neighbour_cost(struct neighbour *neigh)
directions. */
directions. */
a
=
MAX
(
a
,
256
);
a
=
MAX
(
a
,
256
);
b
=
MAX
(
b
,
256
);
b
=
MAX
(
b
,
256
);
/* 1/(alpha * beta), which is just plain ETX. Avoid overflow. */
/* 1/(alpha * beta), which is just plain ETX. */
return
((
a
+
8
)
>>
4
)
*
((
b
+
8
)
>>
4
);
/* Since a and b are capped to 16 bits, overflow is impossible. */
return
(
a
*
b
+
128
)
>>
8
;
}
}
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment