Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
caucase
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
2
Merge Requests
2
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Jobs
Commits
Open sidebar
nexedi
caucase
Commits
3e509b16
Commit
3e509b16
authored
Nov 02, 2018
by
Vincent Pelletier
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
http: Update comment about CRL verification by socket ssl context.
parent
7b9f6e2a
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
9 deletions
+7
-9
caucase/http.py
caucase/http.py
+7
-9
No files found.
caucase/http.py
View file @
3e509b16
...
...
@@ -226,15 +226,13 @@ def getSSLContext(
# If a client wishes to use https for unauthenticated operations, that's
# fine too.
ssl_context
.
verify_mode
=
ssl
.
CERT_OPTIONAL
# Note: it does not seem possible to get python's openssl context to check
# certificate revocation:
# - calling load_verify_locations(cadata=<crl data>) or
# load_verify_locations(cadata=<crl data> + <ca crt data>) raises
# - calling load_verify_locations(cadata=<ca crt data> + <crl data>) fails to
# validate CA completely
# Anyway, wsgi application level is supposed (and automatically tested to)
# verify revocations too, so this should not be a big issue... Still,
# implementation cross-check would have been nice.
# Note: python's standard ssl module does not provide a way to replace the
# current CRL file on an existing openssl context: load_verify_locations ends
# up calling X509_STORE_add_crl, which either adds the CRL to its list of
# files or rejects the file. So either memory usage with increase until
# context gets renewed, or we get stuck with an old CRL. So expect wsgi
# application to implement these checks on its own when accessing client's
# certificate.
#ssl_context.verify_flags = ssl.VERIFY_CRL_CHECK_LEAF
ssl_context
.
load_verify_locations
(
cadata
=
utils
.
toUnicode
(
cau
.
getCACertificate
()),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment