Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
erp5
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
138
Merge Requests
138
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Jobs
Commits
Open sidebar
nexedi
erp5
Commits
00e1736b
Commit
00e1736b
authored
Nov 25, 2019
by
Jérome Perrin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
administration: fixes for pylint
parent
592e3eae
Pipeline
#6857
failed with stage
in 0 seconds
Changes
9
Pipelines
1
Show whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
20 additions
and
25 deletions
+20
-25
bt5/erp5_administration/ExtensionTemplateItem/portal_components/extension.erp5.ERP5Administration.py
...em/portal_components/extension.erp5.ERP5Administration.py
+3
-3
bt5/erp5_administration/ExtensionTemplateItem/portal_components/extension.erp5.ERP5Administration.xml
...m/portal_components/extension.erp5.ERP5Administration.xml
+1
-4
bt5/erp5_administration/ExtensionTemplateItem/portal_components/extension.erp5.pprofile.py
...TemplateItem/portal_components/extension.erp5.pprofile.py
+2
-1
bt5/erp5_administration/ExtensionTemplateItem/portal_components/extension.erp5.pprofile.xml
...emplateItem/portal_components/extension.erp5.pprofile.xml
+1
-4
bt5/erp5_administration/SkinTemplateItem/portal_skins/erp5_administration/Alarm_checkLocalizer.py
.../portal_skins/erp5_administration/Alarm_checkLocalizer.py
+3
-3
bt5/erp5_administration/SkinTemplateItem/portal_skins/erp5_administration/Base_viewSecurityMappingAsUser.py
...ins/erp5_administration/Base_viewSecurityMappingAsUser.py
+6
-5
bt5/erp5_administration/SkinTemplateItem/portal_skins/erp5_administration/BusinessTemplate_getModifiableFieldList.py
...administration/BusinessTemplate_getModifiableFieldList.py
+3
-3
bt5/erp5_administration/SkinTemplateItem/portal_skins/erp5_administration/ERP5Site_checkCatalogTable.py
...l_skins/erp5_administration/ERP5Site_checkCatalogTable.py
+1
-1
bt5/erp5_administration/bt/skip_coding_style_test
bt5/erp5_administration/bt/skip_coding_style_test
+0
-1
No files found.
bt5/erp5_administration/ExtensionTemplateItem/portal_components/extension.erp5.ERP5Administration.py
View file @
00e1736b
...
...
@@ -102,8 +102,8 @@ def MessageCatalog_getNotTranslatedMessageDict(self):
"""
not_translated_message_dict
=
{}
messages
=
MessageCatalog_getMessageDict
(
self
)
for
k
,
v
in
messages
.
iteritems
():
if
not
len
(
v
)
or
not
len
(
filter
(
lambda
x
:
x
,
v
.
values
()))
:
for
k
,
v
in
messages
.
iteritems
():
if
not
[
x
for
x
in
v
.
values
()
if
x
]
:
not_translated_message_dict
[
k
]
=
v
return
not_translated_message_dict
...
...
@@ -153,7 +153,7 @@ def checkConversionToolAvailability(self):
_
,
html_result
=
temp_document
.
convert
(
format
=
'html'
)
except
ConflictError
:
raise
except
:
#Which Errors should we catch ?
except
Exception
:
#Transformation failed
message
=
'Conversion tool got unexpected error:
\
n
%s'
%
''
.
join
(
ExceptionFormatter
.
format_exception
(
*
sys
.
exc_info
()))
else
:
...
...
bt5/erp5_administration/ExtensionTemplateItem/portal_components/extension.erp5.ERP5Administration.xml
View file @
00e1736b
...
...
@@ -45,10 +45,7 @@
<item>
<key>
<string>
text_content_warning_message
</string>
</key>
<value>
<tuple>
<string>
W:106, 29: map/filter on lambda could be replaced by comprehension (deprecated-lambda)
</string>
<string>
W:156, 2: No exception type(s) specified (bare-except)
</string>
</tuple>
<tuple/>
</value>
</item>
<item>
...
...
bt5/erp5_administration/ExtensionTemplateItem/portal_components/extension.erp5.pprofile.py
View file @
00e1736b
from
zpprofile
import
getProfiler
,
getStatisticalProfilerAndThread
# these names are used in external methods
from
zpprofile
import
getProfiler
,
getStatisticalProfilerAndThread
# pylint: disable=unused-import
\ No newline at end of file
bt5/erp5_administration/ExtensionTemplateItem/portal_components/extension.erp5.pprofile.xml
View file @
00e1736b
...
...
@@ -43,10 +43,7 @@
<item>
<key>
<string>
text_content_warning_message
</string>
</key>
<value>
<tuple>
<string>
W: 1, 0: Unused getProfiler imported from zpprofile (unused-import)
</string>
<string>
W: 1, 0: Unused getStatisticalProfilerAndThread imported from zpprofile (unused-import)
</string>
</tuple>
<tuple/>
</value>
</item>
<item>
...
...
bt5/erp5_administration/SkinTemplateItem/portal_skins/erp5_administration/Alarm_checkLocalizer.py
View file @
00e1736b
...
...
@@ -6,13 +6,13 @@ alarm_warn_ratio = 0.25
localizer
=
context
.
Localizer
for
message_catalog
in
localizer
.
objectValues
(
'MessageCatalog'
):
all
=
len
(
message_catalog
.
MessageCatalog_getMessageDict
().
keys
())
all
_messages
=
len
(
message_catalog
.
MessageCatalog_getMessageDict
().
keys
())
not_translated
=
len
(
message_catalog
.
MessageCatalog_getNotTranslatedMessageDict
().
keys
())
enable_warning
=
not_translated
>
all
*
alarm_warn_ratio
enable_warning
=
not_translated
>
all
_messages
*
alarm_warn_ratio
if
enable_warning
:
# we have more than allowed number of untranslated messages,
# fire alarm
context
.
log
(
"Too many untranslated Localizer messages for %s %s/%s"
%
(
message_catalog
,
all
,
not_translated
))
context
.
log
(
"Too many untranslated Localizer messages for %s %s/%s"
%
(
message_catalog
,
all
_messages
,
not_translated
))
return
True
return
False
bt5/erp5_administration/SkinTemplateItem/portal_skins/erp5_administration/Base_viewSecurityMappingAsUser.py
View file @
00e1736b
...
...
@@ -8,13 +8,14 @@ def getDefaultSecurityCategoryMapping():
'ERP5Type_getSecurityCategoryFromAssignment'
,
context
.
getPortalObject
().
getPortalAssignmentBaseCategoryList
()
),)
getSecurityCategoryMapping
=
getattr
(
context
,
'ERP5Type_getSecurityCategoryMapping'
,
getDefaultSecurityCategoryMapping
)
# XXX end of code duplication
for
method_id
,
base_category_list
in
getSecurityCategoryMapping
():
try
:
security_category_dict
.
setdefault
(
tuple
(
base_category_list
),
[]).
extend
(
getattr
(
context
,
method_id
)(
base_category_list
,
login
,
context
,
''
))
except
:
# XXX: it is not possible to log message with traceback from python script
except
Exception
:
# XXX: it is not possible to log message with traceback from python script
print
'It was not possible to invoke method %s with base_category_list %s'
%
(
method_id
,
base_category_list
)
for
base_category_list
,
category_value_list
in
security_category_dict
.
items
():
...
...
bt5/erp5_administration/SkinTemplateItem/portal_skins/erp5_administration/BusinessTemplate_getModifiableFieldList.py
View file @
00e1736b
...
...
@@ -21,11 +21,11 @@ field_library_id_dict = {
modified_object_dict
=
{}
def
calculateFieldLibraryID
(
id
):
def
calculateFieldLibraryID
(
bt_title
):
# The field library name could be automatically calculated or hardcoded in
# the script
return
field_library_id_dict
.
get
(
id
)
or
'Base_view%sFieldLibrary'
%
\
''
.
join
([
x
.
capitalize
()
for
x
in
id
.
split
(
'_'
)[
1
:]])
return
field_library_id_dict
.
get
(
bt_title
)
or
'Base_view%sFieldLibrary'
%
\
''
.
join
([
x
.
capitalize
()
for
x
in
bt_title
.
split
(
'_'
)[
1
:]])
def
getForm
(
skin_folder
,
form_id
):
try
:
...
...
bt5/erp5_administration/SkinTemplateItem/portal_skins/erp5_administration/ERP5Site_checkCatalogTable.py
View file @
00e1736b
...
...
@@ -54,7 +54,7 @@ if catalog_uid_list is None:
'tag'
:
tag
,
'fixit'
:
fixit
,
}
for
activity
in
xrange
(
activity_count
):
for
_
in
xrange
(
activity_count
):
if
len
(
catalog_uid_list
)
==
0
:
result_list
.
append
(
'No more uids to check, stop spawning activities.'
)
break
...
...
bt5/erp5_administration/bt/skip_coding_style_test
deleted
100644 → 0
View file @
592e3eae
1
\ No newline at end of file
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment