Commit 51833ce4 authored by Jérome Perrin's avatar Jérome Perrin

monaco_editor_ui_test: repair test

Something changed in
d89a10a0...6272a90c
parent a68aaed6
Pipeline #6917 passed with stage
in 0 seconds
......@@ -27,7 +27,7 @@
<tr><td colspan="3"><b>Switch to renderjs UI and edit a web page</b></td></tr>
<tr><td>open</td>
<td>${base_url}/web_site_module/renderjs_runner/#/web_page_module/?editable=true</td><td></td></tr>
<td>${base_url}/web_site_module/renderjs_runner/#/web_page_module?editable=true</td><td></td></tr>
<tal:block metal:use-macro="here/Zuite_CommonTemplateForRenderjsUi/macros/wait_for_app_loaded" />
<tr><td>waitForElementPresent</td>
......
  • @romain this fixes the test failure we have on master ( https://nexedijs.erp5.net/#/test_result_module/20191203-360DD799/38 ) but I don't fully understand why :)

    I'm going to apply this patch on master if you don't see any issue with this. Do you have any suggestion for a better commit message ?

  • My mistake, sorry. I was planning to fix it today.

    This regression comes from this regexp which check if form_list is rendered on a module or not.

    It is a bit brutal, but I don't think a more clever solution is needed currently, so I preferred fixing the failing tests.

  • Ah I understand, thank you. You're right even if such URL were working a bit by chance, let's fix the test. I pushed that change after adding a bit of explanation to master as 041b0614

Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment