base: only consider open assignment to initialize preferences

bt5/erp5_base/SkinTemplateItem/portal_skins/erp5_base/Person_createUserPreference.py

@@ -19,6 +19,8 @@ preference.setTitle(translateString('Preference for ${name}',
                      mapping=dict(name=context.getTitle())))
 
 for assignment in context.contentValues(portal_type='Assignment'):
+  if assignment.getValidationState() != 'open':
+    continue
   group = assignment.getGroup(base=True)
   if group:
     preference.setPreferredSectionCategory(group)

bt5/erp5_core_test/TestTemplateItem/portal_components/test.erp5.testERP5Base.py

@@ -1309,6 +1309,12 @@ class TestERP5Base(ERP5TypeTestCase):
                                    site='distibution/tokyo')
     self.assertNotEqual(None, assignment.getGroupValue())
     assignment.open()
+    # unrelated assignment that should be ignored
+    person.newContent(
+      portal_type='Assignment',
+      group='nexedi/rentalinux',
+      site='distibution/new_york',
+    )
     login = person.newContent(
       portal_type="ERP5 Login",
       reference="user_login",