fix a bug that bogus variation category can be left for created lines.

add a comment for further improvement.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@24582 20353a03-c40f-0410-a6d1-a30d3c3de9de

product/ERP5/Document/OrderBuilder.py

@@ -470,6 +470,8 @@ class OrderBuilder(XMLObject, Amount, Predicate):
             parent._duplicate(parent.manage_copyObjects(ids=ids))[0],
             (delivery, old_delivery_line.getId()), {}, CopyError)
           delivery_line = delivery[cp['new_id']]
+          # reset variation category list
+          delivery_line.setVariationCategoryList([])
           # delete non-split movements
           keep_id_list = [y.getDeliveryValue().getId() for y in \
                           movement_group.getMovementList()]
@@ -482,6 +484,8 @@ class OrderBuilder(XMLObject, Amount, Predicate):
         delivery_line.edit(**property_dict)
 
       # Update variation category list on line
+      # XXX updating variation category list should be also handled by
+      # MovementGroup
       line_variation_category_list = delivery_line.getVariationCategoryList()
       for movement in movement_group.getMovementList():
         line_variation_category_list.extend(