Accounting: fix a wrong constraint when checking accounting periods

When we have a transaction with both sections from the same group, we
only check accounting periods for the sides which actually define
accounting. When there was a source or destination organiation defined
at the delivery level it was acquired on the lines and in that check we
wrongly considered this to be defining accounting.

bt5/erp5_accounting/WorkflowTemplateItem/portal_workflow/accounting_workflow/scripts/validateTransaction.py

@@ -65,7 +65,7 @@ if not skip_period_validation :
     valid_date = False
     no_accounts = True
     for line in transaction_line_list:
-      if line.getSource():
+      if line.getSource(portal_type='Account'):
         no_accounts = False
     if no_accounts:
       valid_date = True
@@ -95,7 +95,7 @@ if not skip_period_validation :
     valid_date = False
     no_accounts = True
     for line in transaction_line_list:
-      if line.getDestination():
+      if line.getDestination(portal_type='Account'):
         no_accounts = False
     if no_accounts:
       valid_date = True

product/ERP5/tests/testAccounting.py

@@ -425,6 +425,93 @@ class TestTransactionValidation(AccountingTestCase):
       line.setDestination(None)
     self.portal.portal_workflow.doActionFor(accounting_transaction, 'stop_action')
 
+  def test_UnusedSectionTransactionValidationDateDestination(self):
+    # If a section doesn't have any accounts on its side, we don't check the
+    # accounting period dates. Symetric test of test_UnusedSectionTransactionValidationDate
+    accounting_transaction = self._makeOne(
+               portal_type='Accounting Transaction',
+               start_date=DateTime('2006/03/03'),
+               destination_section_value=self.organisation_module.supplier,
+               source_section_value=self.section,
+               payment_mode='default',
+               lines=(dict(source_value=self.account_module.goods_purchase,
+                           destination_value=self.account_module.goods_purchase,
+                           source_debit=500),
+                      dict(source_value=self.account_module.receivable,
+                           destination_value=self.account_module.receivable,
+                           source_credit=500)))
+
+    # 2006 is closed for source_section
+    self.assertRaises(ValidationFailed,
+        self.portal.portal_workflow.doActionFor,
+        accounting_transaction, 'stop_action')
+    # If we don't have accounts on source side, validating transaction is
+    # not refused
+    for line in accounting_transaction.getMovementList():
+      line.setSource(None)
+    self.portal.portal_workflow.doActionFor(accounting_transaction, 'stop_action')
+
+  def test_UnusedSectionTransactionValidationDateWithSourceSetOnDelivery(self):
+    # If a section doesn't have any accounts on its side, we don't check the
+    # accounting period dates
+    # Corner case that a source organisation is set on the transaction.
+    # Acquisition should not be a problem.
+    accounting_transaction = self._makeOne(
+               portal_type='Accounting Transaction',
+               start_date=DateTime('2006/03/03'),
+               source_section_value=self.organisation_module.supplier,
+               source_value=self.organisation_module.supplier,
+               destination_section_value=self.section,
+               destination_value=self.section,
+               payment_mode='default',
+               lines=(dict(source_value=self.account_module.goods_purchase,
+                           destination_value=self.account_module.goods_purchase,
+                           source_debit=500),
+                      dict(source_value=self.account_module.receivable,
+                           destination_value=self.account_module.receivable,
+                           source_credit=500)))
+
+    # 2006 is closed for destination_section
+    self.assertRaises(ValidationFailed,
+        self.portal.portal_workflow.doActionFor,
+        accounting_transaction, 'stop_action')
+    # If we don't have accounts on destination side, validating transaction is
+    # not refused
+    for line in accounting_transaction.getMovementList():
+      line.setDestination(None)
+    self.portal.portal_workflow.doActionFor(accounting_transaction, 'stop_action')
+
+  def test_UnusedSectionTransactionValidationDateDestinationWithDestinationSetOnDelivery(self):
+    # If a section doesn't have any accounts on its side, we don't check the
+    # accounting period dates.
+    # Symetric test of test_UnusedSectionTransactionValidationDateWithSourceSetOnDelivery
+    # Corner case that a destination organisation is set on the transaction.
+    # Acquisition should not be a problem.
+    accounting_transaction = self._makeOne(
+               portal_type='Accounting Transaction',
+               start_date=DateTime('2006/03/03'),
+               destination_section_value=self.organisation_module.supplier,
+               destination_value=self.organisation_module.supplier,
+               source_section_value=self.section,
+               source_value=self.section,
+               payment_mode='default',
+               lines=(dict(source_value=self.account_module.goods_purchase,
+                           destination_value=self.account_module.goods_purchase,
+                           source_debit=500),
+                      dict(source_value=self.account_module.receivable,
+                           destination_value=self.account_module.receivable,
+                           source_credit=500)))
+
+    # 2006 is closed for source_section
+    self.assertRaises(ValidationFailed,
+        self.portal.portal_workflow.doActionFor,
+        accounting_transaction, 'stop_action')
+    # If we don't have accounts on source side, validating transaction is
+    # not refused
+    for line in accounting_transaction.getMovementList():
+      line.setSource(None)
+    self.portal.portal_workflow.doActionFor(accounting_transaction, 'stop_action')
+
   def test_AccountingTransactionValidationStartDate(self):
     # Check we can/cannot validate at date boundaries of the period
     accounting_transaction = self._makeOne(

[Jérome Perrin]

( tests result OK https://nexedi.erp5.net/test_result_module/20161109-1FDC502E )