Reviewer suggested changes

Including moving min chars override to Milestone

app/models/concerns/timebox.rb

@@ -152,10 +152,6 @@ module Timebox
     def predefined?(timebox)
       predefined_id?(timebox&.id)
     end
-
-    def min_chars_for_partial_matching
-      2
-    end
   end
 
   ##

app/models/milestone.rb

@@ -46,6 +46,10 @@ class Milestone < ApplicationRecord
     state :active
   end
 
+  def self.min_chars_for_partial_matching
+    2
+  end
+
   def self.reference_prefix
     '%'
   end

changelogs/unreleased/ajk-graphql-milestone-filters.yml

 ---
-title: Add filters to the milestones resolver
+title: Add filters on Milestone title in the GraphQL API
 merge_request: 44208
 author:
 type: changed

spec/requests/api/graphql/project/milestones_spec.rb

@@ -52,7 +52,7 @@ RSpec.describe 'getting milestone listings nested in a project' do
   end
 
   shared_examples 'searching with parameters' do
-    it 'finds the right mrs' do
+    it 'finds the right milestones' do
       post_graphql(query, current_user: current_user)
 
       expect(results).to match_array(result_list(expected))