Commit 04fd3292 authored by Siddharth Asthana's avatar Siddharth Asthana Committed by Peter Leitzen

Resolve Rails/LinkToBlank rubocop offenses

Changelog: other
EE: true
parent fa5af694
...@@ -498,12 +498,6 @@ Rails/InverseOf: ...@@ -498,12 +498,6 @@ Rails/InverseOf:
Rails/LexicallyScopedActionFilter: Rails/LexicallyScopedActionFilter:
Enabled: false Enabled: false
# Offense count: 2
# Cop supports --auto-correct.
Rails/LinkToBlank:
Exclude:
- 'app/helpers/projects_helper.rb'
- 'ee/app/helpers/ee/users/callouts_helper.rb'
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct.
......
...@@ -160,7 +160,7 @@ module ProjectsHelper ...@@ -160,7 +160,7 @@ module ProjectsHelper
end end
def link_to_autodeploy_doc def link_to_autodeploy_doc
link_to _('About auto deploy'), help_page_path('topics/autodevops/stages.md', anchor: 'auto-deploy'), target: '_blank' link_to _('About auto deploy'), help_page_path('topics/autodevops/stages.md', anchor: 'auto-deploy'), target: '_blank', rel: 'noopener'
end end
def autodeploy_flash_notice(branch_name) def autodeploy_flash_notice(branch_name)
......
...@@ -140,7 +140,7 @@ module EE ...@@ -140,7 +140,7 @@ module EE
end end
def add_migrate_to_hashed_storage_link(message) def add_migrate_to_hashed_storage_link(message)
migrate_link = link_to(_('For more info, read the documentation.'), help_page_path('administration/raketasks/storage.md', anchor: 'migrate-to-hashed-storage'), target: '_blank') migrate_link = link_to(_('For more info, read the documentation.'), help_page_path('administration/raketasks/storage.md', anchor: 'migrate-to-hashed-storage'), target: '_blank', rel: 'noopener')
linked_message = message % { migrate_link: migrate_link } linked_message = message % { migrate_link: migrate_link }
linked_message.html_safe linked_message.html_safe
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment