Commit 07ea548d authored by Jose Ivan Vargas's avatar Jose Ivan Vargas

Merge branch 'pb-popover-improvement' into 'master'

Update popover placement and cursor on warning icon in performance bar

See merge request gitlab-org/gitlab!58552
parents 75a5d001 ecacb94f
......@@ -58,9 +58,13 @@ export default {
<span v-if="request.hasWarnings">(!)</span>
</option>
</select>
<span v-if="requestsWithWarnings.length">
<span v-if="requestsWithWarnings.length" class="gl-cursor-default">
<span id="performance-bar-request-selector-warning" v-html="glEmojiTag('warning')"></span>
<gl-popover target="performance-bar-request-selector-warning" :content="warningMessage" />
<gl-popover
placement="bottom"
target="performance-bar-request-selector-warning"
:content="warningMessage"
/>
</span>
</div>
</template>
......@@ -35,8 +35,8 @@ export default {
};
</script>
<template>
<span v-if="hasWarnings">
<span v-if="hasWarnings" class="gl-cursor-default">
<span :id="htmlId" v-html="glEmojiTag('warning')"></span>
<gl-popover :target="htmlId" :content="warningMessage" />
<gl-popover placement="bottom" :target="htmlId" :content="warningMessage" />
</span>
</template>
---
title: Update popover placement and cursor on warning icon in PB
merge_request: 58552
author: Yogi (@yo)
type: changed
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment