Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
09a3f41c
Commit
09a3f41c
authored
Mar 18, 2021
by
Matthias Kaeppler
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Drop unused preload from PipelineSerializer
parent
549ea1d9
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
2 deletions
+6
-2
app/serializers/pipeline_serializer.rb
app/serializers/pipeline_serializer.rb
+0
-1
changelogs/unreleased/321788-drop-unused-preload.yml
changelogs/unreleased/321788-drop-unused-preload.yml
+5
-0
spec/serializers/pipeline_serializer_spec.rb
spec/serializers/pipeline_serializer_spec.rb
+1
-1
No files found.
app/serializers/pipeline_serializer.rb
View file @
09a3f41c
...
...
@@ -41,7 +41,6 @@ class PipelineSerializer < BaseSerializer
def
preloaded_relations
[
:cancelable_statuses
,
:latest_statuses_ordered_by_stage
,
:retryable_builds
,
:stages
,
:latest_statuses
,
...
...
changelogs/unreleased/321788-drop-unused-preload.yml
0 → 100644
View file @
09a3f41c
---
title
:
Drop unused preload from PipelineSerializer
merge_request
:
56988
author
:
type
:
performance
spec/serializers/pipeline_serializer_spec.rb
View file @
09a3f41c
...
...
@@ -202,7 +202,7 @@ RSpec.describe PipelineSerializer do
# Existing numbers are high and require performance optimization
# Ongoing issue:
# https://gitlab.com/gitlab-org/gitlab/-/issues/225156
expected_queries
=
Gitlab
.
ee?
?
8
5
:
76
expected_queries
=
Gitlab
.
ee?
?
8
2
:
76
expect
(
recorded
.
count
).
to
be_within
(
2
).
of
(
expected_queries
)
expect
(
recorded
.
cached_count
).
to
eq
(
0
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment