Merge branch 'ld-cop-bulk-insert-global-namespace-fix' into 'master'

`BulkInsert` cop to also check top-level namespace use of `::Gitlab`

See merge request gitlab-org/gitlab!42047

app/services/packages/nuget/create_dependency_service.rb

@@ -41,7 +41,7 @@ module Packages
           }
         end
 
-        ::Gitlab::Database.bulk_insert(::Packages::Nuget::DependencyLinkMetadatum.table_name, rows.compact)
+        ::Gitlab::Database.bulk_insert(::Packages::Nuget::DependencyLinkMetadatum.table_name, rows.compact) # rubocop:disable Gitlab/BulkInsert
       end
 
       def raw_dependency_for(dependency)

app/services/packages/update_tags_service.rb

@@ -15,7 +15,7 @@ module Packages
       tags_to_create = @tags - existing_tags
 
       @package.tags.with_name(tags_to_destroy).delete_all if tags_to_destroy.any?
-      ::Gitlab::Database.bulk_insert(Packages::Tag.table_name, rows(tags_to_create)) if tags_to_create.any?
+      ::Gitlab::Database.bulk_insert(Packages::Tag.table_name, rows(tags_to_create)) if tags_to_create.any? # rubocop:disable Gitlab/BulkInsert
     end
 
     private

ee/app/services/ee/audit_events/bulk_insert_service.rb

@@ -19,7 +19,7 @@ module EE
         return if collection.empty?
 
         collection.in_groups_of(BATCH_SIZE, false) do |services|
-          ::Gitlab::Database.bulk_insert(::AuditEvent.table_name, services.map(&:attributes))
+          ::Gitlab::Database.bulk_insert(::AuditEvent.table_name, services.map(&:attributes)) # rubocop:disable Gitlab/BulkInsert
 
           services.each(&:log_security_event_to_file)
         end

ee/app/services/ee/resource_events/change_weight_service.rb

@@ -13,7 +13,7 @@ module EE
 
       def execute
         unless resource_weight_changes.empty?
-          ::Gitlab::Database.bulk_insert(ResourceWeightEvent.table_name, resource_weight_changes)
+          ::Gitlab::Database.bulk_insert(ResourceWeightEvent.table_name, resource_weight_changes) # rubocop:disable Gitlab/BulkInsert
           resources.each(&:expire_note_etag_cache)
         end
       end

rubocop/cop/gitlab/bulk_insert.rb

@@ -9,7 +9,7 @@ module RuboCop
         MSG = 'Use the `BulkInsertSafe` concern, instead of using `Gitlab::Database.bulk_insert`. See https://docs.gitlab.com/ee/development/insert_into_tables_in_batches.html'
 
         def_node_matcher :raw_union?, <<~PATTERN
-          (send (const (const nil? :Gitlab) :Database) :bulk_insert ...)
+          (send (const (const _ :Gitlab) :Database) :bulk_insert ...)
         PATTERN
 
         def on_send(node)

spec/rubocop/cop/gitlab/bulk_insert_spec.rb

@@ -13,7 +13,14 @@ RSpec.describe RuboCop::Cop::Gitlab::BulkInsert, type: :rubocop do
   it 'flags the use of Gitlab::Database.bulk_insert' do
     expect_offense(<<~SOURCE)
     Gitlab::Database.bulk_insert('merge_request_diff_files', rows)
-    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use the `BulkInsertSafe` concern, instead of using `Gitlab::Database.bulk_insert`. See https://docs.gitlab.com/ee/development/insert_into_tables_in_batches.html
+    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{RuboCop::Cop::Gitlab::BulkInsert::MSG}
+    SOURCE
+  end
+
+  it 'flags the use of ::Gitlab::Database.bulk_insert' do
+    expect_offense(<<~SOURCE)
+    ::Gitlab::Database.bulk_insert('merge_request_diff_files', rows)
+    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{RuboCop::Cop::Gitlab::BulkInsert::MSG}
     SOURCE
   end
 end