Merge branch 'issue#325836-fix-empty-line-after-let-it-be-gitlab-graphql' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/graphql

See merge request gitlab-org/gitlab!58261

.rubocop_manual_todo.yml

@@ -840,12 +840,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/lib/gitlab/github_import/importer/pull_request_review_importer_spec.rb
     - spec/lib/gitlab/github_import/milestone_finder_spec.rb
     - spec/lib/gitlab/gl_repository/repo_type_spec.rb
-    - spec/lib/gitlab/graphql/batch_key_spec.rb
-    - spec/lib/gitlab/graphql/docs/renderer_spec.rb
-    - spec/lib/gitlab/graphql/loaders/batch_lfs_oid_loader_spec.rb
-    - spec/lib/gitlab/graphql/markdown_field_spec.rb
-    - spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb
-    - spec/lib/gitlab/graphql/pagination/keyset/last_items_spec.rb
     - spec/lib/gitlab/group_search_results_spec.rb
     - spec/lib/gitlab/hook_data/issue_builder_spec.rb
     - spec/lib/gitlab/hook_data/merge_request_builder_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlab-graphql.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/graphql
+merge_request: 58261
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/gitlab/graphql/batch_key_spec.rb

@@ -6,6 +6,7 @@ require 'test_prof/recipes/rspec/let_it_be'
 RSpec.describe ::Gitlab::Graphql::BatchKey do
   let_it_be(:rect) { Struct.new(:len, :width) }
   let_it_be(:circle) { Struct.new(:radius) }
+
   let(:lookahead) { nil }
   let(:object) { rect.new(2, 3) }
 

spec/lib/gitlab/graphql/loaders/batch_lfs_oid_loader_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Gitlab::Graphql::Loaders::BatchLfsOidLoader do
   include GraphqlHelpers
 
   let_it_be(:project) { create(:project, :repository) }
+
   let(:repository) { project.repository }
   let(:blob) { Gitlab::Graphql::Representation::TreeEntry.new(repository.blob_at('master', 'files/lfs/lfs_object.iso'), repository) }
   let(:otherblob) { Gitlab::Graphql::Representation::TreeEntry.new(repository.blob_at('master', 'README'), repository) }

spec/lib/gitlab/graphql/markdown_field_spec.rb

@@ -57,6 +57,7 @@ RSpec.describe Gitlab::Graphql::MarkdownField do
 
       describe 'basic verification that references work' do
         let_it_be(:project) { create(:project, :public) }
+
         let(:issue) { create(:issue, project: project) }
         let(:note) { build(:note, note: "Referencing #{issue.to_reference(full: true)}") }
 

spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb

@@ -337,6 +337,7 @@ RSpec.describe Gitlab::Graphql::Pagination::Keyset::Connection do
 
   describe '#nodes' do
     let_it_be(:all_nodes) { create_list(:project, 5) }
+
     let(:paged_nodes) { subject.nodes }
 
     it_behaves_like 'connection with paged nodes' do

spec/lib/gitlab/graphql/pagination/keyset/last_items_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::Graphql::Pagination::Keyset::LastItems do
   let_it_be(:merge_request) { create(:merge_request) }
+
   let(:scope) { MergeRequest.order_merged_at_asc }
 
   subject { described_class.take_items(*args) }