Commit 0f0ca29f authored by Maxime Orefice's avatar Maxime Orefice Committed by Douglas Barbosa Alexandre

Enable coverage_report_view feature flag by default

parent 7ae4af48
...@@ -1374,7 +1374,7 @@ class MergeRequest < ApplicationRecord ...@@ -1374,7 +1374,7 @@ class MergeRequest < ApplicationRecord
end end
def has_coverage_reports? def has_coverage_reports?
return false unless Feature.enabled?(:coverage_report_view, project) return false unless Feature.enabled?(:coverage_report_view, project, default_enabled: true)
actual_head_pipeline&.has_coverage_reports? actual_head_pipeline&.has_coverage_reports?
end end
......
---
title: Enable coverage_report_view feature flag by default
merge_request: 42094
author: fh1ch
type: performance
...@@ -8,14 +8,11 @@ type: reference, howto ...@@ -8,14 +8,11 @@ type: reference, howto
# Test Coverage Visualization **(CORE ONLY)** # Test Coverage Visualization **(CORE ONLY)**
> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/3708) in GitLab 12.9. > - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/3708) in GitLab 12.9.
> - It's [deployed behind a feature flag](../../../user/feature_flags.md), disabled by default. > - [Feature flag enabled](https://gitlab.com/gitlab-org/gitlab/-/issues/211410) in GitLab 13.4.
> - It's disabled on GitLab.com. > - It's enabled on GitLab.com.
> - It can be enabled or disabled per-project. > - It can be disabled per-project.
> - To use it in GitLab self-managed instances, ask a GitLab administrator to [enable it](#enabling-the-feature). **(CORE ONLY)** > - To use it in GitLab self-managed instances, ask a GitLab administrator to [enable it](#enabling-the-feature). **(CORE ONLY)**
CAUTION: **Caution:**
This feature might not be available to you. Check the **version history** note above for details.
With the help of [GitLab CI/CD](../../../ci/README.md), you can collect the test With the help of [GitLab CI/CD](../../../ci/README.md), you can collect the test
coverage information of your favorite testing or coverage-analysis tool, and visualize coverage information of your favorite testing or coverage-analysis tool, and visualize
this information inside the file diff view of your merge requests (MRs). This will allow you this information inside the file diff view of your merge requests (MRs). This will allow you
...@@ -79,11 +76,9 @@ test: ...@@ -79,11 +76,9 @@ test:
## Enabling the feature ## Enabling the feature
This feature comes with the `:coverage_report_view` feature flag disabled by This feature comes with the `:coverage_report_view` feature flag enabled by
default. It is disabled on GitLab.com. This feature is disabled due to some performance issues with very large default. It is enabled on GitLab.com. [GitLab administrators with access to the GitLab Rails console](../../../administration/feature_flags.md)
data sets. When [the performance issue](https://gitlab.com/gitlab-org/gitlab/-/issues/211410) can disable it for your instance. Test coverage visualization can be enabled or disabled per-project.
is resolved, the feature will be enabled by default. [GitLab administrators with access to the GitLab Rails console](../../../administration/feature_flags.md)
can enable it for your instance. Test coverage visualization can be enabled or disabled per-project.
To enable it: To enable it:
......
...@@ -63,7 +63,7 @@ module Gitlab ...@@ -63,7 +63,7 @@ module Gitlab
end end
def self.coverage_report_view?(project) def self.coverage_report_view?(project)
::Feature.enabled?(:coverage_report_view, project) ::Feature.enabled?(:coverage_report_view, project, default_enabled: true)
end end
def self.child_of_child_pipeline_enabled?(project) def self.child_of_child_pipeline_enabled?(project)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment