Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0fadca7f
Commit
0fadca7f
authored
Aug 02, 2019
by
Lucas Charles
Committed by
Evan Read
Aug 02, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add documentation for Security Approvals for MRs
Documents how to enable security approvals
parent
4a4b863b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
42 additions
and
0 deletions
+42
-0
doc/user/application_security/index.md
doc/user/application_security/index.md
+32
-0
doc/user/project/merge_requests/merge_request_approvals.md
doc/user/project/merge_requests/merge_request_approvals.md
+10
-0
No files found.
doc/user/application_security/index.md
View file @
0fadca7f
...
@@ -148,6 +148,38 @@ Clicking on this button will create a merge request to apply the solution onto t
...
@@ -148,6 +148,38 @@ Clicking on this button will create a merge request to apply the solution onto t
![
Create merge request from vulnerability
](
img/create_issue_with_list_hover.png
)
![
Create merge request from vulnerability
](
img/create_issue_with_list_hover.png
)
## Security approvals in merge requests **(ULTIMATE)**
> [Introduced](https://gitlab.com/gitlab-org/gitlab-ee/issues/9928) in [GitLab Ultimate](https://about.gitlab.com/pricing) 12.2.
Merge Request Approvals can be configured to require approval from a member
of your security team when a vulnerability would be introduced by a merge request.
This threshold is defined as
`high`
,
`critical`
, or
`unknown`
severity. When any vulnerabilities are present within a merge request, an
approval will be required from the
`Vulnerability-Check`
approver group.
### Enabling Security Approvals within a project
To enable Security Approvals, a
[
project approval rule
](
../project/merge_requests/merge_request_approvals.md#multiple-approval-rules-premium
)
must be created with the case-sensitive name
`Vulnerability-Check`
. This approval
group must be set with an "Approvals required" count greater than zero.
Once this group has been added to your project, the approval rule will be enabled
for all Merge Requests.
Any code changes made will cause the count of approvals required to reset.
An approval will be required when a security report:
-
Contains a new vulnerability of
`high`
,
`critical`
, or
`unknown`
severity.
-
Is not generated during pipeline execution.
An approval will be optional when a security report:
-
Contains no new vulnerabilities.
-
Contains only new vulnerabilities of
`low`
or
`medium`
severity.
<!-- ## Troubleshooting
<!-- ## Troubleshooting
Include any troubleshooting steps that you can foresee. If you know beforehand what issues
Include any troubleshooting steps that you can foresee. If you know beforehand what issues
...
...
doc/user/project/merge_requests/merge_request_approvals.md
View file @
0fadca7f
...
@@ -331,6 +331,16 @@ the dropdown) `approver` and select the user.
...
@@ -331,6 +331,16 @@ the dropdown) `approver` and select the user.
![
Filter MRs by an approver
](
img/filter_approver_merge_requests.png
)
![
Filter MRs by an approver
](
img/filter_approver_merge_requests.png
)
## Security approvals in merge requests **(ULTIMATE)**
> Introduced in [GitLab Ultimate](https://about.gitlab.com/pricing) 12.2.
Merge Request Approvals can be configured to require approval from a member
of your security team when a vulnerability would be introduced by a merge request.
For more information, see
[
Security approvals in merge requests
](
../../application_security/index.md#security-approvals-in-merge-requests-ultimate
)
.
<!-- ## Troubleshooting
<!-- ## Troubleshooting
Include any troubleshooting steps that you can foresee. If you know beforehand what issues
Include any troubleshooting steps that you can foresee. If you know beforehand what issues
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment