Merge branch 'chore/iife-removal' into 'master'

Remove IIFEs from notes

Closes #34611

See merge request gitlab-org/gitlab!20025

app/assets/javascripts/notes.js

-/* eslint-disable no-restricted-properties, func-names, no-var, camelcase,
+/* eslint-disable no-restricted-properties, no-var, camelcase,
 no-unused-expressions, one-var, default-case,
-consistent-return, no-alert, no-return-assign,
-no-param-reassign, no-else-return, vars-on-top,
-no-shadow, no-useless-escape, class-methods-use-this */
+consistent-return, no-alert, no-param-reassign, no-else-return,
+vars-on-top, no-shadow, no-useless-escape,
+class-methods-use-this */
 
 /* global ResolveService */
 
@@ -281,14 +281,7 @@ export default class Notes {
     if (Notes.interval) {
       clearInterval(Notes.interval);
     }
-    return (Notes.interval = setInterval(
-      (function(_this) {
-        return function() {
-          return _this.refresh();
-        };
-      })(this),
-      this.pollingInterval,
-    ));
+    Notes.interval = setInterval(() => this.refresh(), this.pollingInterval);
   }
 
   refresh() {
@@ -847,15 +840,12 @@ export default class Notes {
     var noteElId, $note;
     $note = $(e.currentTarget).closest('.note');
     noteElId = $note.attr('id');
-    $(`.note[id="${noteElId}"]`).each(
-      (function() {
+    $(`.note[id="${noteElId}"]`).each((i, el) => {
       // A same note appears in the "Discussion" and in the "Changes" tab, we have
       // to remove all. Using $('.note[id='noteId']') ensure we get all the notes,
       // where $('#noteId') would return only one.
-        return function(i, el) {
-          var $note, $notes;
-          $note = $(el);
-          $notes = $note.closest('.discussion-notes');
+      const $note = $(el);
+      const $notes = $note.closest('.discussion-notes');
       const discussionId = $('.notes', $notes).data('discussionId');
 
       if (typeof gl.diffNotesCompileComponents !== 'undefined') {
@@ -868,7 +858,7 @@ export default class Notes {
 
       // check if this is the last note for this line
       if ($notes.find('.note').length === 0) {
-            var notesTr = $notes.closest('tr');
+        const notesTr = $notes.closest('tr');
 
         // "Discussions" tab
         $notes.closest('.timeline-entry').remove();
@@ -895,9 +885,7 @@ export default class Notes {
           notesTr.remove();
         }
       }
-        };
-      })(this),
-    );
+    });
 
     Notes.checkMergeRequestStatus();
     return this.updateNotesCount(-1);