Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
11e99e53
Commit
11e99e53
authored
Feb 25, 2022
by
Samantha Ming
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Refactor metric constant name
Add action suffix so to match other constant name.
parent
f05e078f
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
5 deletions
+5
-5
app/assets/javascripts/security_configuration/constants.js
app/assets/javascripts/security_configuration/constants.js
+1
-1
ee/app/assets/javascripts/vulnerabilities/components/vulnerability_training.vue
...pts/vulnerabilities/components/vulnerability_training.vue
+2
-2
ee/spec/frontend/vulnerabilities/vulnerability_training_spec.js
...c/frontend/vulnerabilities/vulnerability_training_spec.js
+2
-2
No files found.
app/assets/javascripts/security_configuration/constants.js
View file @
11e99e53
export
const
TRACK_TOGGLE_TRAINING_PROVIDER_ACTION
=
'
toggle_security_training_provider
'
;
export
const
TRACK_TOGGLE_TRAINING_PROVIDER_LABEL
=
'
update_security_training_provider
'
;
export
const
TRACK_CLICK_TRAINING_LINK
=
'
click_security_training_link
'
;
export
const
TRACK_CLICK_TRAINING_LINK
_ACTION
=
'
click_security_training_link
'
;
export
const
TRACK_PROVIDER_LEARN_MORE_CLICK_ACTION
=
'
click_link
'
;
export
const
TRACK_PROVIDER_LEARN_MORE_CLICK_LABEL
=
'
security_training_provider
'
;
export
const
TRACK_TRAINING_LOADED_ACTION
=
'
security_training_link_loaded
'
;
ee/app/assets/javascripts/vulnerabilities/components/vulnerability_training.vue
View file @
11e99e53
...
...
@@ -7,7 +7,7 @@ import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin';
import
axios
from
'
~/lib/utils/axios_utils
'
;
import
Tracking
from
'
~/tracking
'
;
import
{
TRACK_CLICK_TRAINING_LINK
,
TRACK_CLICK_TRAINING_LINK
_ACTION
,
TRACK_TRAINING_LOADED_ACTION
,
}
from
'
~/security_configuration/constants
'
;
import
{
SUPPORTED_IDENTIFIER_TYPES
}
from
'
../constants
'
;
...
...
@@ -127,7 +127,7 @@ export default {
}
},
clickTrainingLink
()
{
this
.
triggerMetric
(
TRACK_CLICK_TRAINING_LINK
);
this
.
triggerMetric
(
TRACK_CLICK_TRAINING_LINK
_ACTION
);
},
triggerMetric
(
action
)
{
const
{
name
}
=
this
.
supportedIdentifier
;
...
...
ee/spec/frontend/vulnerabilities/vulnerability_training_spec.js
View file @
11e99e53
...
...
@@ -15,7 +15,7 @@ import securityTrainingProvidersQuery from '~/security_configuration/graphql/sec
import
{
shallowMountExtended
}
from
'
helpers/vue_test_utils_helper
'
;
import
{
SUPPORTED_IDENTIFIER_TYPES
}
from
'
ee/vulnerabilities/constants
'
;
import
{
TRACK_CLICK_TRAINING_LINK
,
TRACK_CLICK_TRAINING_LINK
_ACTION
,
TRACK_TRAINING_LOADED_ACTION
,
}
from
'
~/security_configuration/constants
'
;
import
createMockApollo
from
'
helpers/mock_apollo_helper
'
;
...
...
@@ -236,7 +236,7 @@ describe('VulnerabilityTraining component', () => {
expect
(
trackingSpy
).
toHaveBeenCalledWith
(
undefined
,
TRACK_CLICK_TRAINING_LINK
,
TRACK_CLICK_TRAINING_LINK
_ACTION
,
expectedTrackingOptions
,
);
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment