Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
129dfa33
Commit
129dfa33
authored
Jul 13, 2020
by
Vitali Tatarintev
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Check whether PagerDuty setting is active
Check whether PagerDuty setting is active when creating incident issue
parent
60fa2032
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
63 additions
and
36 deletions
+63
-36
app/services/concerns/incident_management/settings.rb
app/services/concerns/incident_management/settings.rb
+2
-0
app/services/incident_management/pager_duty/create_incident_issue_service.rb
...nt_management/pager_duty/create_incident_issue_service.rb
+4
-1
spec/services/incident_management/pager_duty/create_incident_issue_service_spec.rb
...nagement/pager_duty/create_incident_issue_service_spec.rb
+56
-35
spec/workers/incident_management/pager_duty/process_incident_worker_spec.rb
...ent_management/pager_duty/process_incident_worker_spec.rb
+1
-0
No files found.
app/services/concerns/incident_management/settings.rb
View file @
129dfa33
# frozen_string_literal: true
module
IncidentManagement
module
Settings
include
Gitlab
::
Utils
::
StrongMemoize
def
incident_management_setting
strong_memoize
(
:incident_management_setting
)
do
project
.
incident_management_setting
||
...
...
app/services/incident_management/pager_duty/create_incident_issue_service.rb
View file @
129dfa33
...
...
@@ -3,6 +3,8 @@
module
IncidentManagement
module
PagerDuty
class
CreateIncidentIssueService
<
BaseService
include
IncidentManagement
::
Settings
def
initialize
(
project
,
incident_payload
)
super
(
project
,
User
.
alert_bot
,
incident_payload
)
end
...
...
@@ -38,7 +40,8 @@ module IncidentManagement
end
def
webhook_available?
Feature
.
enabled?
(
:pagerduty_webhook
,
project
)
Feature
.
enabled?
(
:pagerduty_webhook
,
project
)
&&
incident_management_setting
.
pagerduty_active?
end
def
forbidden
...
...
spec/services/incident_management/pager_duty/create_incident_issue_service_spec.rb
View file @
129dfa33
...
...
@@ -3,7 +3,7 @@
require
'spec_helper'
RSpec
.
describe
IncidentManagement
::
PagerDuty
::
CreateIncidentIssueService
do
let_it_be
(
:project
)
{
create
(
:project
)
}
let_it_be
(
:project
,
reload:
true
)
{
create
(
:project
)
}
let_it_be
(
:user
)
{
User
.
alert_bot
}
let
(
:webhook_payload
)
{
Gitlab
::
Json
.
parse
(
fixture_file
(
'pager_duty/webhook_incident_trigger.json'
))
}
let
(
:parsed_payload
)
{
::
PagerDuty
::
WebhookPayloadParser
.
call
(
webhook_payload
)
}
...
...
@@ -17,6 +17,9 @@ RSpec.describe IncidentManagement::PagerDuty::CreateIncidentIssueService do
stub_feature_flags
(
pagerduty_webhook:
project
)
end
context
'when PagerDuty webhook setting is active'
do
let_it_be
(
:incident_management_setting
)
{
create
(
:project_incident_management_setting
,
project:
project
,
pagerduty_active:
true
)
}
context
'when issue can be created'
do
it
'creates a new issue'
do
expect
{
execute
}.
to
change
(
Issue
,
:count
).
by
(
1
)
...
...
@@ -55,9 +58,13 @@ RSpec.describe IncidentManagement::PagerDuty::CreateIncidentIssueService do
end
end
context
'when issue cannot be created
'
do
context
'when the payload does not contain a title
'
do
let
(
:incident_payload
)
{
{}
}
it
'does not create a GitLab issue'
do
expect
{
execute
}.
not_to
change
(
Issue
,
:count
)
end
it
'responds with error'
do
expect
(
execute
).
to
be_error
expect
(
execute
.
message
).
to
eq
(
"Title can't be blank"
)
...
...
@@ -65,6 +72,20 @@ RSpec.describe IncidentManagement::PagerDuty::CreateIncidentIssueService do
end
end
context
'when PagerDuty webhook setting is not active'
do
let_it_be
(
:incident_management_setting
)
{
create
(
:project_incident_management_setting
,
project:
project
,
pagerduty_active:
false
)
}
it
'does not create a GitLab issue'
do
expect
{
execute
}.
not_to
change
(
Issue
,
:count
)
end
it
'responds with forbidden'
do
expect
(
execute
).
to
be_error
expect
(
execute
.
http_status
).
to
eq
(
:forbidden
)
end
end
end
context
'when pagerduty_webhook feature disabled'
do
before
do
stub_feature_flags
(
pagerduty_webhook:
false
)
...
...
spec/workers/incident_management/pager_duty/process_incident_worker_spec.rb
View file @
129dfa33
...
...
@@ -4,6 +4,7 @@ require 'spec_helper'
RSpec
.
describe
IncidentManagement
::
PagerDuty
::
ProcessIncidentWorker
do
let_it_be
(
:project
)
{
create
(
:project
)
}
let_it_be
(
:incident_management_setting
)
{
create
(
:project_incident_management_setting
,
project:
project
,
pagerduty_active:
true
)
}
describe
'#perform'
do
subject
(
:perform
)
{
described_class
.
new
.
perform
(
project
.
id
,
incident_payload
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment