Split out load_ methods and simplify condition

Don't put code in large if blocks, but do an early return instead.

ee/app/models/geo_node_status.rb

@@ -145,13 +145,6 @@ class GeoNodeStatus < ApplicationRecord
   end
 
   def load_data_from_current_node
-    self.status_message =
-      begin
-        HealthCheck::Utils.process_checks(['geo'])
-      rescue NotImplementedError => e
-        e.to_s
-      end
-
     latest_event = Geo::EventLog.latest_event
     self.last_event_id = latest_event&.id
     self.last_event_date = latest_event&.created_at
@@ -175,14 +168,25 @@ class GeoNodeStatus < ApplicationRecord
     self.hashed_storage_attachments_max_id = Geo::HashedStorageAttachmentsEvent.maximum(:id)
     self.projects_count = geo_node.projects.count
 
+    load_status_message
     load_primary_data
     load_secondary_data
 
     self
   end
 
+  def load_status_message
+    self.status_message =
+      begin
+        HealthCheck::Utils.process_checks(['geo'])
+      rescue NotImplementedError => e
+        e.to_s
+      end
+  end
+
   def load_primary_data
-    if Gitlab::Geo.primary?
+    return unless Gitlab::Geo.primary?
+
     self.lfs_objects_count = LfsObject.syncable.count
     self.job_artifacts_count = Ci::JobArtifact.syncable.count
     self.attachments_count = Upload.syncable.count
@@ -197,14 +201,13 @@ class GeoNodeStatus < ApplicationRecord
       self.wikis_checksummed_count = repository_verification_finder.count_verified_wikis
       self.wikis_checksum_failed_count = repository_verification_finder.count_verification_failed_wikis
     end
-
-      self.repositories_checked_count = Project.where.not(last_repository_check_at: nil).count
-      self.repositories_checked_failed_count = Project.where(last_repository_check_failed: true).count
-    end
   end
 
+
+
   def load_secondary_data # rubocop:disable Metrics/AbcSize
-    if Gitlab::Geo.secondary?
+    return unless Gitlab::Geo.secondary?
+
     self.db_replication_lag_seconds = Gitlab::Geo::HealthCheck.new.db_replication_lag_seconds
     self.cursor_last_event_id = current_cursor_last_event_id
     self.cursor_last_event_date = Geo::EventLog.find_by(id: self.cursor_last_event_id)&.created_at
@@ -233,10 +236,10 @@ class GeoNodeStatus < ApplicationRecord
     self.repositories_checked_count = Geo::ProjectRegistry.where.not(last_repository_check_at: nil).count
     self.repositories_checked_failed_count = Geo::ProjectRegistry.where(last_repository_check_failed: true).count
   end
-  end
 
   def load_verification_data
-    if repository_verification_enabled
+    return unless repository_verification_enabled
+
     self.repositories_verified_count = registries_for_verified_projects(:repository).count
     self.repositories_verification_failed_count = registries_for_verification_failed_projects(:repository).count
     self.repositories_checksum_mismatch_count = registries_for_mismatch_projects(:repository).count
@@ -246,7 +249,6 @@ class GeoNodeStatus < ApplicationRecord
     self.repositories_retrying_verification_count = registries_retrying_verification(:repository).count
     self.wikis_retrying_verification_count = registries_retrying_verification(:wiki).count
   end
-  end
 
   def current_cursor_last_event_id
     return unless Gitlab::Geo.secondary?