Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
18bc0ca5
Commit
18bc0ca5
authored
Apr 20, 2021
by
Pedro Moreira da Silva
Committed by
Marcia Ramos
Apr 20, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Direct to MR guidelines on how to write descriptions
parent
62937d9a
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
2 deletions
+4
-2
doc/development/code_review.md
doc/development/code_review.md
+4
-2
No files found.
doc/development/code_review.md
View file @
18bc0ca5
...
@@ -299,8 +299,10 @@ first time.
...
@@ -299,8 +299,10 @@ first time.
of your shiny new branch, read through the entire diff. Does it make sense?
of your shiny new branch, read through the entire diff. Does it make sense?
Did you include something unrelated to the overall purpose of the changes? Did
Did you include something unrelated to the overall purpose of the changes? Did
you forget to remove any debugging code?
you forget to remove any debugging code?
-
Consider providing instructions on how to test the merge request. This can be
-
Write a detailed description as outlined in the
[
merge request guidelines
](
contributing/merge_request_workflow.md#merge-request-guidelines
)
.
helpful for reviewers not familiar with the product feature or area of the codebase.
Some reviewers may not be familiar with the product feature or area of the
codebase. Thorough descriptions help all reviewers understand your request
and test effectively.
-
If you know your change depends on another being merged first, note it in the
-
If you know your change depends on another being merged first, note it in the
description and set an
[
merge request dependency
](
../user/project/merge_requests/merge_request_dependencies.md
)
.
description and set an
[
merge request dependency
](
../user/project/merge_requests/merge_request_dependencies.md
)
.
-
Be grateful for the reviewer's suggestions. (
`Good call. I'll make that change.`
)
-
Be grateful for the reviewer's suggestions. (
`Good call. I'll make that change.`
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment