Boards - Remove List model from GraphQL boards

Review feedback

app/assets/javascripts/boards/boards_util.js

@@ -13,11 +13,10 @@ export function updateListPosition(listObj) {
   if (listType === ListType.closed) {
     position = Infinity;
   } else if (listType === ListType.backlog) {
-    position = -1;
+    position = -Infinity;
   }
 
-  const list = { ...listObj, position };
-  return list;
+  return { ...listObj, position };
 }
 
 export function formatBoardLists(lists) {

app/assets/javascripts/boards/components/issue_card_inner.vue

@@ -126,7 +126,7 @@ export default {
       return (
         label.id &&
         !(
-          (this.list.type === ListType.label || this.list.listType === ListType.label) &&
+          (this.list.type || this.list.listType) === ListType.label &&
           this.list.title === label.title
         )
       );

app/assets/javascripts/boards/components/project_select.vue

@@ -54,10 +54,7 @@ export default {
         this.loading = true;
         const additionalAttrs = {};
 
-        if (
-          (this.list.type && this.list.type !== ListType.backlog) ||
-          (this.list.listType && this.list.listType !== ListType.backlog)
-        ) {
+        if ((this.list.type || this.list.listType) !== ListType.backlog) {
           additionalAttrs.min_access_level = featureAccessLevel.EVERYONE;
         }
 

spec/frontend/boards/components/board_list_header_new_spec.js

@@ -73,6 +73,7 @@ describe('Board List Header Component', () => {
   const isExpanded = () => !isCollapsed;
 
   const findAddIssueButton = () => wrapper.find({ ref: 'newIssueBtn' });
+  const findTitle = () => wrapper.find('.board-title');
   const findCaret = () => wrapper.find('.board-title-caret');
 
   describe('Add issue button', () => {
@@ -163,4 +164,24 @@ describe('Board List Header Component', () => {
       expect(localStorage.getItem(`${wrapper.vm.uniqueKey}.expanded`)).toBe(String(isExpanded()));
     });
   });
+
+  describe('user can drag', () => {
+    const cannotDragList = [ListType.backlog, ListType.closed];
+    const canDragList = [ListType.label, ListType.milestone, ListType.assignee];
+
+    it.each(cannotDragList)(
+      'does not have user-can-drag-class so user cannot drag list',
+      listType => {
+        createComponent({ listType });
+
+        expect(findTitle().classes()).not.toContain('user-can-drag');
+      },
+    );
+
+    it.each(canDragList)('has user-can-drag-class so user can drag list', listType => {
+      createComponent({ listType });
+
+      expect(findTitle().classes()).toContain('user-can-drag');
+    });
+  });
 });