Commit 1b0bcd9d authored by Jan Provaznik's avatar Jan Provaznik

Disable project metric label

Having project label causes significant cardinality in service desk
metrics, second problem is that because these service desk events are
relatively rare, there are not enough events for some pods and data in
rate graphs are misrepresented.
parent 80a2d99c
...@@ -42,10 +42,6 @@ module Gitlab ...@@ -42,10 +42,6 @@ module Gitlab
end end
end end
def metrics_params
super.merge(project: project&.full_path)
end
def metrics_event def metrics_event
:receive_email_service_desk :receive_email_service_desk
end end
......
...@@ -54,7 +54,7 @@ RSpec.describe Gitlab::Email::Handler::ServiceDeskHandler do ...@@ -54,7 +54,7 @@ RSpec.describe Gitlab::Email::Handler::ServiceDeskHandler do
it 'adds metric events for incoming and reply emails' do it 'adds metric events for incoming and reply emails' do
metric_transaction = double('Gitlab::Metrics::WebTransaction', increment: true, observe: true) metric_transaction = double('Gitlab::Metrics::WebTransaction', increment: true, observe: true)
allow(::Gitlab::Metrics::BackgroundTransaction).to receive(:current).and_return(metric_transaction) allow(::Gitlab::Metrics::BackgroundTransaction).to receive(:current).and_return(metric_transaction)
expect(metric_transaction).to receive(:add_event).with(:receive_email_service_desk, anything) expect(metric_transaction).to receive(:add_event).with(:receive_email_service_desk, { handler: 'Gitlab::Email::Handler::ServiceDeskHandler' })
expect(metric_transaction).to receive(:add_event).with(:service_desk_thank_you_email) expect(metric_transaction).to receive(:add_event).with(:service_desk_thank_you_email)
receiver.execute receiver.execute
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment