Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1ce28983
Commit
1ce28983
authored
Jul 09, 2020
by
Illya Klymov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make incompatible_repos consistent accross all controllers
Unify incompatible_repos behavior with other protected methods
parent
c4ae74fd
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
11 additions
and
1 deletion
+11
-1
app/controllers/import/base_controller.rb
app/controllers/import/base_controller.rb
+1
-1
app/controllers/import/fogbugz_controller.rb
app/controllers/import/fogbugz_controller.rb
+5
-0
app/controllers/import/gitlab_controller.rb
app/controllers/import/gitlab_controller.rb
+5
-0
No files found.
app/controllers/import/base_controller.rb
View file @
1ce28983
...
@@ -30,7 +30,7 @@ class Import::BaseController < ApplicationController
...
@@ -30,7 +30,7 @@ class Import::BaseController < ApplicationController
end
end
def
incompatible_repos
def
incompatible_repos
[]
raise
NotImplementedError
end
end
def
provider_name
def
provider_name
...
...
app/controllers/import/fogbugz_controller.rb
View file @
1ce28983
...
@@ -89,6 +89,11 @@ class Import::FogbugzController < Import::BaseController
...
@@ -89,6 +89,11 @@ class Import::FogbugzController < Import::BaseController
end
end
# rubocop: enable CodeReuse/ActiveRecord
# rubocop: enable CodeReuse/ActiveRecord
override
:incompatible_repos
def
incompatible_repos
[]
end
override
:provider_name
override
:provider_name
def
provider_name
def
provider_name
:fogbugz
:fogbugz
...
...
app/controllers/import/gitlab_controller.rb
View file @
1ce28983
...
@@ -54,6 +54,11 @@ class Import::GitlabController < Import::BaseController
...
@@ -54,6 +54,11 @@ class Import::GitlabController < Import::BaseController
end
end
# rubocop: enable CodeReuse/ActiveRecord
# rubocop: enable CodeReuse/ActiveRecord
override
:incompatible_repos
def
incompatible_repos
[]
end
override
:provider_name
override
:provider_name
def
provider_name
def
provider_name
:gitlab
:gitlab
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment