Commit 1e25d605 authored by Kushal Pandya's avatar Kushal Pandya

Merge branch '207322-remove-redundant-slots' into 'master'

Refactor redundant divs on Kubernetes apps page

See merge request gitlab-org/gitlab!33452
parents 60921a97 f0c4a3bb
...@@ -339,7 +339,9 @@ export default { ...@@ -339,7 +339,9 @@ export default {
class="js-cluster-application-installed-via" class="js-cluster-application-installed-via"
v-html="installedVia" v-html="installedVia"
></span> ></span>
<div>
<slot name="description"></slot> <slot name="description"></slot>
</div>
<div v-if="hasError" class="cluster-application-error text-danger prepend-top-10"> <div v-if="hasError" class="cluster-application-error text-danger prepend-top-10">
<p class="js-cluster-application-general-error-message gl-mb-0"> <p class="js-cluster-application-general-error-message gl-mb-0">
{{ generalErrorDescription }} {{ generalErrorDescription }}
......
...@@ -218,14 +218,12 @@ export default { ...@@ -218,14 +218,12 @@ export default {
title-link="https://docs.helm.sh/" title-link="https://docs.helm.sh/"
> >
<template #description> <template #description>
<div>
{{ {{
s__(`ClusterIntegration|Helm streamlines installing s__(`ClusterIntegration|Helm streamlines installing
and managing Kubernetes applications. and managing Kubernetes applications.
Tiller runs inside of your Kubernetes Cluster, Tiller runs inside of your Kubernetes Cluster,
and manages releases of your charts.`) and manages releases of your charts.`)
}} }}
</div>
</template> </template>
</application-row> </application-row>
<div v-show="!helmInstalled" class="cluster-application-warning"> <div v-show="!helmInstalled" class="cluster-application-warning">
...@@ -257,7 +255,6 @@ export default { ...@@ -257,7 +255,6 @@ export default {
title-link="https://kubernetes.io/docs/concepts/services-networking/ingress/" title-link="https://kubernetes.io/docs/concepts/services-networking/ingress/"
> >
<template #description> <template #description>
<div>
<p> <p>
{{ {{
s__(`ClusterIntegration|Ingress gives you a way to route s__(`ClusterIntegration|Ingress gives you a way to route
...@@ -273,9 +270,7 @@ export default { ...@@ -273,9 +270,7 @@ export default {
<template v-if="ingressInstalled"> <template v-if="ingressInstalled">
<div class="form-group"> <div class="form-group">
<label for="ingress-endpoint">{{ <label for="ingress-endpoint">{{ s__('ClusterIntegration|Ingress Endpoint') }}</label>
s__('ClusterIntegration|Ingress Endpoint')
}}</label>
<div class="input-group"> <div class="input-group">
<template v-if="ingressExternalEndpoint"> <template v-if="ingressExternalEndpoint">
<input <input
...@@ -342,7 +337,6 @@ export default { ...@@ -342,7 +337,6 @@ export default {
</strong> </strong>
</div> </div>
</template> </template>
</div>
</template> </template>
</application-row> </application-row>
<application-row <application-row
...@@ -363,7 +357,6 @@ export default { ...@@ -363,7 +357,6 @@ export default {
title-link="https://cert-manager.readthedocs.io/en/latest/#" title-link="https://cert-manager.readthedocs.io/en/latest/#"
> >
<template #description> <template #description>
<div>
<p> <p>
<gl-sprintf <gl-sprintf
:message=" :message="
...@@ -404,7 +397,6 @@ export default { ...@@ -404,7 +397,6 @@ export default {
> >
</p> </p>
</div> </div>
</div>
</template> </template>
</application-row> </application-row>
<application-row <application-row
...@@ -463,14 +455,12 @@ export default { ...@@ -463,14 +455,12 @@ export default {
title-link="https://docs.gitlab.com/runner/" title-link="https://docs.gitlab.com/runner/"
> >
<template #description> <template #description>
<div>
{{ {{
s__(`ClusterIntegration|GitLab Runner connects to the s__(`ClusterIntegration|GitLab Runner connects to the
repository and executes CI/CD jobs, repository and executes CI/CD jobs,
pushing results back and deploying pushing results back and deploying
applications to production.`) applications to production.`)
}} }}
</div>
</template> </template>
</application-row> </application-row>
<application-row <application-row
...@@ -491,7 +481,6 @@ export default { ...@@ -491,7 +481,6 @@ export default {
title-link="https://crossplane.io" title-link="https://crossplane.io"
> >
<template #description> <template #description>
<div>
<p> <p>
<gl-sprintf <gl-sprintf
:message=" :message="
...@@ -516,7 +505,6 @@ export default { ...@@ -516,7 +505,6 @@ export default {
<div class="form-group"> <div class="form-group">
<CrossplaneProviderStack :crossplane="crossplane" @set="setCrossplaneProviderStack" /> <CrossplaneProviderStack :crossplane="crossplane" @set="setCrossplaneProviderStack" />
</div> </div>
</div>
</template> </template>
</application-row> </application-row>
...@@ -538,7 +526,6 @@ export default { ...@@ -538,7 +526,6 @@ export default {
title-link="https://jupyterhub.readthedocs.io/en/stable/" title-link="https://jupyterhub.readthedocs.io/en/stable/"
> >
<template #description> <template #description>
<div>
<p> <p>
{{ {{
s__(`ClusterIntegration|JupyterHub, a multi-user Hub, spawns, s__(`ClusterIntegration|JupyterHub, a multi-user Hub, spawns,
...@@ -551,9 +538,7 @@ export default { ...@@ -551,9 +538,7 @@ export default {
<template v-if="ingressExternalEndpoint"> <template v-if="ingressExternalEndpoint">
<div class="form-group"> <div class="form-group">
<label for="jupyter-hostname">{{ <label for="jupyter-hostname">{{ s__('ClusterIntegration|Jupyter Hostname') }}</label>
s__('ClusterIntegration|Jupyter Hostname')
}}</label>
<div class="input-group"> <div class="input-group">
<input <input
...@@ -583,7 +568,6 @@ export default { ...@@ -583,7 +568,6 @@ export default {
</p> </p>
</div> </div>
</template> </template>
</div>
</template> </template>
</application-row> </application-row>
<application-row <application-row
...@@ -610,7 +594,6 @@ export default { ...@@ -610,7 +594,6 @@ export default {
title-link="https://github.com/knative/docs" title-link="https://github.com/knative/docs"
> >
<template #description> <template #description>
<div>
<p v-if="!rbac" class="rbac-notice bs-callout bs-callout-info"> <p v-if="!rbac" class="rbac-notice bs-callout bs-callout-info">
{{ {{
s__(`ClusterIntegration|You must have an RBAC-enabled cluster s__(`ClusterIntegration|You must have an RBAC-enabled cluster
...@@ -634,7 +617,6 @@ export default { ...@@ -634,7 +617,6 @@ export default {
@save="saveKnativeDomain" @save="saveKnativeDomain"
@set="setKnativeDomain" @set="setKnativeDomain"
/> />
</div>
</template> </template>
</application-row> </application-row>
<application-row <application-row
...@@ -659,7 +641,6 @@ export default { ...@@ -659,7 +641,6 @@ export default {
title-link="https://gitlab.com/gitlab-org/charts/elastic-stack" title-link="https://gitlab.com/gitlab-org/charts/elastic-stack"
> >
<template #description> <template #description>
<div>
<p> <p>
{{ {{
s__( s__(
...@@ -667,7 +648,6 @@ export default { ...@@ -667,7 +648,6 @@ export default {
) )
}} }}
</p> </p>
</div>
</template> </template>
</application-row> </application-row>
...@@ -696,7 +676,6 @@ export default { ...@@ -696,7 +676,6 @@ export default {
title-link="https://github.com/helm/charts/tree/master/stable/fluentd" title-link="https://github.com/helm/charts/tree/master/stable/fluentd"
> >
<template #description> <template #description>
<div>
<p> <p>
{{ {{
s__( s__(
...@@ -714,7 +693,6 @@ export default { ...@@ -714,7 +693,6 @@ export default {
:status="applications.fluentd.status" :status="applications.fluentd.status"
:update-failed="applications.fluentd.updateFailed" :update-failed="applications.fluentd.updateFailed"
/> />
</div>
</template> </template>
</application-row> </application-row>
</div> </div>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment