Commit 1f16e36c authored by Wei-Meng Lee's avatar Wei-Meng Lee

Merge branch 'hchouraria-admin-plantuml-redirect-note-tls-browsers' into 'master'

PlantUML note about redirects when using TLS

See merge request gitlab-org/gitlab!50599
parents 37983a16 b24a843a
...@@ -90,8 +90,8 @@ the configuration below accordingly. ...@@ -90,8 +90,8 @@ the configuration below accordingly.
### Making local PlantUML accessible using custom GitLab setup ### Making local PlantUML accessible using custom GitLab setup
The PlantUML server runs locally on your server, so it is not accessible The PlantUML server runs locally on your server, so it is not accessible
externally. As such, it is necessary to catch external PlantUML calls and externally by default. As such, it is necessary to catch external PlantUML
redirect them to the local server. calls and redirect them to the local server.
The idea is to redirect each call to `https://gitlab.example.com/-/plantuml/` The idea is to redirect each call to `https://gitlab.example.com/-/plantuml/`
to the local PlantUML server `http://plantuml:8080/` or `http://localhost:8080/plantuml/`, depending on your setup. to the local PlantUML server `http://plantuml:8080/` or `http://localhost:8080/plantuml/`, depending on your setup.
...@@ -112,6 +112,12 @@ To activate the changes, run the following command: ...@@ -112,6 +112,12 @@ To activate the changes, run the following command:
sudo gitlab-ctl reconfigure sudo gitlab-ctl reconfigure
``` ```
Note that the redirection through GitLab **must** be configured
when running [GitLab with TLS](https://docs.gitlab.com/omnibus/settings/ssl.html)
due to PlantUML's use of the insecure HTTP protocol. Newer browsers such
as [Google Chrome 86+](https://www.chromestatus.com/feature/4926989725073408)
do not load insecure HTTP resources on a page served over HTTPS.
### Security ### Security
PlantUML has features that allows fetching network resources. PlantUML has features that allows fetching network resources.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment