remove selector string option from Subscription constructor

1f6ec183 · Mike Greiling · eed2de20 · 1f6ec183
Commit 1f6ec183 authored Dec 01, 2016 by Mike Greiling
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 5 deletions

app/assets/javascripts/subscription.js.es6 app/assets/javascripts/subscription.js.es6 +3 -5

No files found.
--- a/app/assets/javascripts/subscription.js.es6
+++ b/app/assets/javascripts/subscription.js.es6
@@ -2,12 +2,10 @@

 (() => {
  class Subscription {
-    constructor(containerSelector) {
-      this.containerElm = (typeof containerSelector === 'string')
-        ? document.querySelector(containerSelector)
-        : containerSelector;
+    constructor(containerElm) {
+      this.containerElm = containerElm;

-      const subscribeButton = this.containerElm.querySelector('.js-subscribe-button');
+      const subscribeButton = containerElm.querySelector('.js-subscribe-button');
      if (subscribeButton) {
        // remove class so we don't bind twice
        subscribeButton.classList.remove('js-subscribe-button');