Merge branch '342120-remove-feature-flag-member_destroy_async_auth_refresh' into 'master'

Remove feature flag: member_destroy_async_auth_refresh

See merge request gitlab-org/gitlab!72338

app/models/member.rb

@@ -188,7 +188,7 @@ class Member < ApplicationRecord
   end
 
   after_commit on: [:destroy], unless: :importing? do
-    refresh_member_authorized_projects(blocking: Feature.disabled?(:member_destroy_async_auth_refresh, type: :ops))
+    refresh_member_authorized_projects(blocking: false)
   end
 
   default_value_for :notification_level, NotificationSetting.levels[:global]

config/feature_flags/ops/member_destroy_async_auth_refresh.yml

----
-name: member_destroy_async_auth_refresh
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/66424
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/342120
-milestone: '14.4'
-type: ops
-group: group::access
-default_enabled: false

ee/spec/services/app_sec/dast/profiles/update_service_spec.rb

@@ -180,12 +180,11 @@ RSpec.describe AppSec::Dast::Profiles::UpdateService do
 
             context 'when the owner was removed from the project' do
               before do
-                stub_feature_flags(member_destroy_async_auth_refresh: false)
                 project.team.truncate
                 project.add_developer(user)
               end
 
-              it 'updates the schedule owner' do
+              it 'updates the schedule owner', :sidekiq_inline do
                 subject
 
                 expect(dast_profile_schedule.user_id).to eq(user.id)

spec/models/members/project_member_spec.rb

@@ -244,32 +244,17 @@ RSpec.describe ProjectMember do
         project.add_user(user, Gitlab::Access::GUEST)
       end
 
-      context 'when :member_destroy_async_auth_refresh feature flag is enabled' do
-        it 'changes access level', :sidekiq_inline do
-          expect { action }.to change { user.can?(:guest_access, project) }.from(true).to(false)
-        end
-
-        it 'calls AuthorizedProjectUpdate::ProjectRecalculatePerUserWorker to recalculate authorizations' do
-          expect(AuthorizedProjectUpdate::ProjectRecalculatePerUserWorker).to receive(:perform_async).with(project.id, user.id)
-
-          action
-        end
-
-        it_behaves_like 'calls AuthorizedProjectUpdate::UserRefreshFromReplicaWorker with a delay to update project authorizations'
+      it 'changes access level', :sidekiq_inline do
+        expect { action }.to change { user.can?(:guest_access, project) }.from(true).to(false)
       end
 
-      context 'when :member_destroy_async_auth_refresh feature flag is disabled' do
-        before do
-          stub_feature_flags(member_destroy_async_auth_refresh: false)
-        end
-
-        it 'changes access level' do
-          expect { action }.to change { user.can?(:guest_access, project) }.from(true).to(false)
-        end
+      it 'calls AuthorizedProjectUpdate::ProjectRecalculatePerUserWorker to recalculate authorizations' do
+        expect(AuthorizedProjectUpdate::ProjectRecalculatePerUserWorker).to receive(:perform_async).with(project.id, user.id)
 
-        it_behaves_like 'calls AuthorizedProjectUpdate::ProjectRecalculatePerUserService to recalculate authorizations'
-        it_behaves_like 'calls AuthorizedProjectUpdate::UserRefreshFromReplicaWorker with a delay to update project authorizations'
+        action
       end
+
+      it_behaves_like 'calls AuthorizedProjectUpdate::UserRefreshFromReplicaWorker with a delay to update project authorizations'
     end
 
     context 'when the feature flag `specialized_service_for_project_member_auth_refresh` is disabled' do