Geo clone/pull/push for not yet replicated repos

Also, avoid private project enumeration by
redirecting 'always'.

ee/app/controllers/ee/repositories/git_http_client_controller.rb

@@ -55,7 +55,8 @@ module EE
           'lfs_locks_api' => %w{create unlock verify}
         }.freeze
 
-        def initialize(controller_name, action_name, service)
+        def initialize(project, controller_name, action_name, service)
+          @project = project
           @controller_name = controller_name
           @action_name = action_name
           @service = service
@@ -67,12 +68,20 @@ module EE
 
         def redirect?
           !!CONTROLLER_AND_ACTIONS_TO_REDIRECT[controller_name]&.include?(action_name) ||
-            git_receive_pack_request?
+            git_receive_pack_request? ||
+            redirect_to_avoid_enumeration? ||
+            not_yet_replicated_redirect?
+        end
+
+        def not_yet_replicated_redirect?
+          return false unless project
+
+          git_upload_pack_request? && !::Geo::ProjectRegistry.repository_replicated_for?(project.id)
         end
 
         private
 
-        attr_reader :service
+        attr_reader :project, :service
 
         # Examples:
         #
@@ -94,6 +103,14 @@ module EE
           service_or_action_name == 'git-receive-pack'
         end
 
+        # Matches:
+        #
+        # GET /repo.git/info/refs?service=git-upload-pack
+        #
+        def git_upload_pack_request?
+          service_or_action_name == 'git-upload-pack'
+        end
+
         # Matches:
         #
         # GET /repo.git/info/refs
@@ -101,12 +118,23 @@ module EE
         def info_refs_request?
           action_name == 'info_refs'
         end
+
+        # The purpose of the #redirect_to_avoid_enumeration? method is to avoid
+        # a scenario where an authenticated user uses the HTTP responses as a
+        # way of enumerating private projects.  Without this check, an attacker
+        # could determine if a project exists or not by looking at the initial
+        # HTTP response code for 401 (doesn't exist) vs 302. (exists).
+        #
+        def redirect_to_avoid_enumeration?
+          project.nil?
+        end
       end
 
       class GeoGitLFSHelper
         MINIMUM_GIT_LFS_VERSION = '2.4.2'.freeze
 
-        def initialize(geo_route_helper, operation, current_version)
+        def initialize(project, geo_route_helper, operation, current_version)
+          @project = project
           @geo_route_helper = geo_route_helper
           @operation = operation
           @current_version = current_version
@@ -122,6 +150,7 @@ module EE
 
         def redirect?
           return true if batch_upload?
+          return true if not_yet_replicated_redirect?
 
           false
         end
@@ -134,7 +163,7 @@ module EE
 
         private
 
-        attr_reader :geo_route_helper, :operation, :current_version
+        attr_reader :project, :geo_route_helper, :operation, :current_version
 
         def incorrect_version_message
           translation = _("You need git-lfs version %{min_git_lfs_version} (or greater) to continue. Please visit https://git-lfs.github.com")
@@ -149,18 +178,32 @@ module EE
           batch_request? && operation == 'upload'
         end
 
+        def batch_download?
+          batch_request? && operation == 'download'
+        end
+
+        def transfer_download?
+          geo_route_helper.match?('lfs_storage', 'download')
+        end
+
+        def not_yet_replicated_redirect?
+          return false unless project
+
+          (batch_download? || transfer_download?) && !::Geo::ProjectRegistry.repository_replicated_for?(project.id)
+        end
+
         def wanted_version
           ::Gitlab::VersionInfo.parse(MINIMUM_GIT_LFS_VERSION)
         end
       end
 
       def geo_route_helper
-        @geo_route_helper ||= GeoRouteHelper.new(controller_name, action_name, params[:service])
+        @geo_route_helper ||= GeoRouteHelper.new(project, controller_name, action_name, params[:service])
       end
 
       def geo_git_lfs_helper
         # params[:operation] explained: https://github.com/git-lfs/git-lfs/blob/master/docs/api/batch.md#requests
-        @geo_git_lfs_helper ||= GeoGitLFSHelper.new(geo_route_helper, params[:operation], request.headers['User-Agent'])
+        @geo_git_lfs_helper ||= GeoGitLFSHelper.new(project, geo_route_helper, params[:operation], request.headers['User-Agent'])
       end
 
       def geo_request_fullpath_for_primary
@@ -169,7 +212,13 @@ module EE
       end
 
       def geo_primary_full_url
-        path = File.join(geo_secondary_referrer_path_prefix, geo_request_fullpath_for_primary)
+        path = if geo_route_helper.not_yet_replicated_redirect?
+                 # git clone/pull
+                 geo_request_fullpath_for_primary
+               else
+                 # git push
+                 File.join(geo_secondary_referrer_path_prefix, geo_request_fullpath_for_primary)
+               end
 
         ::Gitlab::Utils.append_path(::Gitlab::Geo.primary_node.internal_url, path)
       end

ee/changelogs/unreleased/202035-geo-http-clone-pull-redirect-to-primary-redirect.yml

+---
+title: Geo - Support git clone/pull operations for repositories that are not yet replicated
+merge_request: 27072
+author:
+type: added

ee/spec/requests/git_http_geo_spec.rb

@@ -9,9 +9,13 @@ describe "Git HTTP requests (Geo)", :geo do
   include WorkhorseHelpers
   using RSpec::Parameterized::TableSyntax
 
-  let_it_be(:project) { create(:project, :repository, :private) }
-  let_it_be(:primary) { create(:geo_node, :primary) }
-  let_it_be(:secondary) { create(:geo_node) }
+  let_it_be(:project_with_repo) { create(:project, :repository, :private) }
+  let_it_be(:project_no_repo) { create(:project, :private) }
+
+  let_it_be(:primary_url) { 'http://primary.example.com' }
+  let_it_be(:secondary_url) { 'http://secondary.example.com' }
+  let_it_be(:primary) { create(:geo_node, :primary, url: primary_url) }
+  let_it_be(:secondary) { create(:geo_node, url: secondary_url) }
 
   # Ensure the token always comes from the real time of the request
   let(:auth_token) { Gitlab::Geo::BaseRequest.new(scope: project.full_path).authorization }
@@ -26,8 +30,12 @@ describe "Git HTTP requests (Geo)", :geo do
   let(:auth_token_with_invalid_scope) { Gitlab::Geo::BaseRequest.new(scope: "invalid").authorization }
 
   before do
-    project.add_maintainer(user)
-    project.add_guest(user_without_push_access)
+    project_with_repo.add_maintainer(user)
+    project_with_repo.add_guest(user_without_push_access)
+    create(:geo_project_registry, :synced, project: project_with_repo)
+
+    project_no_repo.add_maintainer(user)
+    project_no_repo.add_guest(user_without_push_access)
 
     stub_licensed_features(geo: true)
     stub_current_geo_node(current_node)
@@ -36,7 +44,56 @@ describe "Git HTTP requests (Geo)", :geo do
     auth_token
   end
 
-  shared_examples_for 'Geo request' do
+  shared_examples_for 'a Geo 200 git request' do
+    subject do
+      make_request
+      response
+    end
+
+    context 'valid Geo JWT token' do
+      it 'returns an OK response with JSON data' do
+        is_expected.to have_gitlab_http_status(:ok)
+
+        expect(response.content_type).to eq(Gitlab::Workhorse::INTERNAL_API_CONTENT_TYPE)
+        expect(json_response).to include('ShowAllRefs' => true)
+      end
+    end
+  end
+
+  shared_examples_for 'a Geo 200 git-lfs request' do
+    subject do
+      make_request
+      response
+    end
+
+    context 'valid Geo JWT token' do
+      it 'returns an OK response with binary data' do
+        is_expected.to have_gitlab_http_status(:ok)
+
+        expect(response.content_type).to eq('application/octet-stream')
+      end
+    end
+  end
+
+  shared_examples_for 'a Geo 302 redirect to Primary' do
+    # redirect_url needs to be defined when using this shared example
+
+    subject do
+      make_request
+      response
+    end
+
+    context 'valid Geo JWT token' do
+      it 'returns a redirect response' do
+        is_expected.to have_gitlab_http_status(:redirect)
+
+        expect(response.content_type).to eq('text/html')
+        expect(response.headers['Location']).to eq(redirect_url)
+      end
+    end
+  end
+
+  shared_examples_for 'a Geo git request' do
     subject do
       make_request
       response
@@ -56,15 +113,6 @@ describe "Git HTTP requests (Geo)", :geo do
       it { is_expected.to have_gitlab_http_status(:unauthorized) }
     end
 
-    context 'valid Geo JWT token' do
-      it 'returns an OK response' do
-        is_expected.to have_gitlab_http_status(:ok)
-
-        expect(response.content_type).to eq(Gitlab::Workhorse::INTERNAL_API_CONTENT_TYPE)
-        expect(json_response).to include('ShowAllRefs' => true)
-      end
-    end
-
     context 'no Geo JWT token' do
       let(:env) { workhorse_internal_api_request_header }
 
@@ -83,42 +131,106 @@ describe "Git HTTP requests (Geo)", :geo do
   context 'when current node is a secondary' do
     let(:current_node) { secondary }
 
-    let_it_be(:project) { create(:project, :repository, :private) }
-
     describe 'GET info_refs' do
       context 'git pull' do
         def make_request
           get "/#{project.full_path}.git/info/refs", params: { service: 'git-upload-pack' }, headers: env
         end
 
-        it_behaves_like 'Geo request'
+        context 'when the repository exists' do
+          context 'but has not successfully synced' do
+            let_it_be(:project_with_repo_but_not_synced) { create(:project, :repository, :private) }
+            let_it_be(:project) { project_with_repo_but_not_synced }
+            let(:redirect_url) { "#{primary_url}/#{project_with_repo_but_not_synced.full_path}.git/info/refs?service=git-upload-pack" }
+
+            before do
+              create(:geo_project_registry, :synced, project: project_with_repo_but_not_synced, last_repository_successful_sync_at: nil)
+            end
+
+            it_behaves_like 'a Geo 302 redirect to Primary'
+
+            context 'when terms are enforced' do
+              before do
+                enforce_terms
+              end
+
+              it_behaves_like 'a Geo 302 redirect to Primary'
+            end
+          end
+
+          context 'and has successfully synced' do
+            let_it_be(:project) { project_with_repo }
+
+            it_behaves_like 'a Geo git request'
+            it_behaves_like 'a Geo 200 git request'
 
             context 'when terms are enforced' do
               before do
                 enforce_terms
               end
 
-          it_behaves_like 'Geo request'
+              it_behaves_like 'a Geo git request'
+              it_behaves_like 'a Geo 200 git request'
+            end
+          end
+        end
+
+        context 'when the repository does not exist' do
+          let_it_be(:project) { project_no_repo }
+          let(:redirect_url) { "#{primary_url}/#{project.full_path}.git/info/refs?service=git-upload-pack" }
+
+          it_behaves_like 'a Geo 302 redirect to Primary'
+
+          context 'when terms are enforced' do
+            before do
+              enforce_terms
+            end
+
+            it_behaves_like 'a Geo 302 redirect to Primary'
+          end
+        end
+
+        context 'when the project does not exist' do
+          # Override #make_request so we can use a non-existent project path
+          def make_request
+            get "/#{non_existent_project_path}.git/info/refs", params: { service: 'git-upload-pack' }, headers: env
+          end
+
+          let(:project) { nil }
+          let(:auth_token) { nil }
+          let(:non_existent_project_path) { 'non-existent-namespace/non-existent-project' }
+          let(:endpoint_path) { "/#{non_existent_project_path}.git/info/refs?service=git-upload-pack" }
+          let(:redirect_url) { redirected_primary_url }
+
+          # To avoid enumeration of private projects not in selective sync,
+          # this response must be the same as a private project without a repo.
+          it_behaves_like 'a Geo 302 redirect to Primary'
+
+          context 'when terms are enforced' do
+            before do
+              enforce_terms
+            end
+
+            it_behaves_like 'a Geo 302 redirect to Primary'
+          end
         end
       end
 
       context 'git push' do
         def make_request
-          get url, params: { service: 'git-receive-pack' }, headers: env
+          get endpoint_path, params: { service: 'git-receive-pack' }, headers: env
         end
 
-        let(:url) { "/#{project.full_path}.git/info/refs" }
+        let_it_be(:project) { project_with_repo }
+        let(:endpoint_path) { "/#{project.full_path}.git/info/refs" }
+        let(:redirect_url) { "#{redirected_primary_url}?service=git-receive-pack" }
 
         subject do
           make_request
           response
         end
 
-        it 'redirects to the primary' do
-          is_expected.to have_gitlab_http_status(:redirect)
-          redirect_location = "#{redirected_primary_url}?service=git-receive-pack"
-          expect(subject.header['Location']).to eq(redirect_location)
-        end
+        it_behaves_like 'a Geo 302 redirect to Primary'
       end
     end
 
@@ -127,26 +239,48 @@ describe "Git HTTP requests (Geo)", :geo do
         post "/#{project.full_path}.git/git-upload-pack", params: {}, headers: env
       end
 
-      it_behaves_like 'Geo request'
+      context 'when the repository exists' do
+        let_it_be(:project) { project_with_repo }
+
+        it_behaves_like 'a Geo git request'
+        it_behaves_like 'a Geo 200 git request'
+
+        context 'when terms are enforced' do
+          before do
+            enforce_terms
+          end
+
+          it_behaves_like 'a Geo git request'
+          it_behaves_like 'a Geo 200 git request'
+        end
+      end
+
+      context 'when the repository does not exist' do
+        let_it_be(:project) { project_no_repo }
+        let(:redirect_url) { "#{primary_url}/#{project.full_path}.git/git-upload-pack" }
+
+        it_behaves_like 'a Geo 302 redirect to Primary'
 
         context 'when terms are enforced' do
           before do
             enforce_terms
           end
 
-        it_behaves_like 'Geo request'
+          it_behaves_like 'a Geo 302 redirect to Primary'
+        end
       end
     end
 
     context 'git-lfs' do
-      context 'API' do
-        describe 'POST batch' do
+      context 'Batch API' do
+        describe 'POST /namespace/repo.git/info/lfs/objects/batch' do
           def make_request
-            post url, params: args, headers: env
+            post endpoint_path, params: args, headers: env
           end
 
           let(:args) { {} }
-          let(:url) { "/#{project.full_path}.git/info/lfs/objects/batch" }
+          let_it_be(:project) { project_with_repo }
+          let(:endpoint_path) { "/#{project.full_path}.git/info/lfs/objects/batch" }
 
           subject do
             make_request
@@ -161,20 +295,17 @@ describe "Git HTTP requests (Geo)", :geo do
 
           context 'operation upload' do
             let(:args) { { 'operation' => 'upload' }.to_json }
+            let(:redirect_url) { redirected_primary_url }
 
-            context 'with the correct git-lfs version' do
+            context 'with a valid git-lfs version' do
               before do
                 env['User-Agent'] = 'git-lfs/2.4.2 (GitHub; darwin amd64; go 1.10.2)'
               end
 
-              it 'redirects to the primary' do
-                is_expected.to have_gitlab_http_status(:redirect)
-                redirect_location = "#{redirected_primary_url}"
-                expect(subject.header['Location']).to eq(redirect_location)
-              end
+              it_behaves_like 'a Geo 302 redirect to Primary'
             end
 
-            context 'with an incorrect git-lfs version' do
+            context 'with an invalid git-lfs version' do
               where(:description, :version) do
                 'outdated' | 'git-lfs/2.4.1'
                 'unknown'  | 'git-lfs'
@@ -209,11 +340,23 @@ describe "Git HTTP requests (Geo)", :geo do
             before do
               project.add_maintainer(user)
               env['Authorization'] = authorization
+              env['User-Agent'] = "2.4.2 (GitHub; darwin amd64; go 1.10.2)"
             end
 
+            context 'when the repository exists' do
+              let_it_be(:project) { project_with_repo }
+
               it 'is handled by the secondary' do
                 is_expected.to have_gitlab_http_status(:ok)
               end
+            end
+
+            context 'when the repository does not exist' do
+              let_it_be(:project) { project_no_repo }
+              let(:redirect_url) { redirected_primary_url }
+
+              it_behaves_like 'a Geo 302 redirect to Primary'
+            end
 
             where(:description, :version) do
               'outdated' | 'git-lfs/2.4.1'
@@ -235,6 +378,47 @@ describe "Git HTTP requests (Geo)", :geo do
         end
       end
 
+      context 'Transfer API' do
+        describe 'GET /namespace/repo.git/gitlab-lfs/objects/<oid>' do
+          def make_request
+            get endpoint_path, headers: env
+          end
+
+          let(:user) { create(:user) }
+          let(:lfs_object) { create(:lfs_object, :with_file) }
+          let(:endpoint_path) { "/#{project.full_path}.git/gitlab-lfs/objects/#{lfs_object.oid}" }
+          let(:authorization) { ActionController::HttpAuthentication::Basic.encode_credentials(user.username, user.password) }
+
+          subject do
+            make_request
+            response
+          end
+
+          before do
+            allow(Gitlab.config.lfs).to receive(:enabled).and_return(true)
+            project.update_attribute(:lfs_enabled, true)
+            project.lfs_objects << lfs_object
+
+            project.add_maintainer(user)
+            env['Authorization'] = authorization
+            env['User-Agent'] = "2.4.2 (GitHub; darwin amd64; go 1.10.2)"
+          end
+
+          context 'when the repository exists' do
+            let_it_be(:project) { project_with_repo }
+
+            it_behaves_like 'a Geo 200 git-lfs request'
+          end
+
+          context 'when the repository does not exist' do
+            let_it_be(:project) { project_no_repo }
+            let(:redirect_url) { redirected_primary_url }
+
+            it_behaves_like 'a Geo 302 redirect to Primary'
+          end
+        end
+      end
+
       context 'Locks API' do
         where(:description, :path, :args) do
           'create' | 'info/lfs/locks'          | {}
@@ -245,28 +429,26 @@ describe "Git HTTP requests (Geo)", :geo do
         with_them do
           describe "POST #{description}" do
             def make_request
-              post url, params: args, headers: env
+              post endpoint_path, params: args, headers: env
             end
 
-            let(:url) { "/#{project.full_path}.git/#{path}" }
+            let_it_be(:project) { project_with_repo }
+            let(:endpoint_path) { "/#{project.full_path}.git/#{path}" }
+            let(:redirect_url) { redirected_primary_url }
 
             subject do
               make_request
               response
             end
 
-            it 'redirects to the primary' do
-              is_expected.to have_gitlab_http_status(:redirect)
-              redirect_location = "#{redirected_primary_url}"
-              expect(subject.header['Location']).to eq(redirect_location)
-            end
+            it_behaves_like 'a Geo 302 redirect to Primary'
           end
         end
       end
     end
 
     def redirected_primary_url
-      "#{primary.url.chomp('/')}#{::Gitlab::Geo::GitPushHttp::PATH_PREFIX}/#{secondary.id}#{url}"
+      "#{primary.url.chomp('/')}#{::Gitlab::Geo::GitPushHttp::PATH_PREFIX}/#{secondary.id}#{endpoint_path}"
     end
   end
 
@@ -281,12 +463,13 @@ describe "Git HTTP requests (Geo)", :geo do
 
       context 'when HTTP redirected from a secondary node' do
         def make_request
-          post url, headers: auth_env(user.username, user.password, nil)
+          post endpoint_path, headers: auth_env(user.username, user.password, nil)
         end
 
         let(:identifier) { "user-#{user.id}" }
+        let_it_be(:project) { project_with_repo }
         let(:gl_repository) { "project-#{project.id}" }
-        let(:url) { "#{::Gitlab::Geo::GitPushHttp::PATH_PREFIX}/#{secondary.id}/#{project.full_path}.git/git-receive-pack" }
+        let(:endpoint_path) { "#{::Gitlab::Geo::GitPushHttp::PATH_PREFIX}/#{secondary.id}/#{project.full_path}.git/git-receive-pack" }
 
         # The bigger picture request flow relevant to this feature is:
         #
@@ -314,10 +497,11 @@ describe "Git HTTP requests (Geo)", :geo do
 
       context 'when proxying an SSH request from a secondary node' do
         def make_request
-          post url, params: {}, headers: env
+          post endpoint_path, params: {}, headers: env
         end
 
-        let(:url) { "/#{project.full_path}.git/git-receive-pack" }
+        let_it_be(:project) { project_with_repo }
+        let(:endpoint_path) { "/#{project.full_path}.git/git-receive-pack" }
 
         before do
           env['Geo-GL-Id'] = geo_gl_id
@@ -401,11 +585,12 @@ describe "Git HTTP requests (Geo)", :geo do
 
       def make_request
         full_path = project.full_path
-        project.destroy
 
         get "/#{full_path}.git/info/refs", params: { service: 'git-upload-pack' }, headers: env
       end
 
+      let_it_be(:project) { project_no_repo }
+
       it { is_expected.to have_gitlab_http_status(:not_found) }
     end
 
@@ -419,6 +604,8 @@ describe "Git HTTP requests (Geo)", :geo do
         get "/#{repository_path}.git/info/refs", params: { service: 'git-upload-pack' }, headers: env
       end
 
+      let_it_be(:project) { project_with_repo }
+
       shared_examples_for 'unauthorized because of invalid scope' do
         it { is_expected.to have_gitlab_http_status(:unauthorized) }
 
@@ -466,6 +653,7 @@ describe "Git HTTP requests (Geo)", :geo do
         get "/#{repository_path}.git/info/refs", params: { service: 'git-upload-pack' }, headers: env
       end
 
+      let_it_be(:project) { project_with_repo }
       let(:repository_path) { project.full_path }
 
       it 'returns unauthorized error' do